Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new error codes and improve some explanations #34467

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

GuillaumeGomez
Copy link
Member

@@ -16,6 +16,8 @@
register_long_diagnostics! {

E0154: r##"
## WARNING: Unused error code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this can be clearer about what it means to be unused. As a warning this sounds like the user has done something wrong. What about something like 'Note: this error code is no longer emitted by the compiler.'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@GuillaumeGomez
Copy link
Member Author

Updated.

@brson
Copy link
Contributor

brson commented Jun 27, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jun 27, 2016

📌 Commit 58955de has been approved by brson

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 29, 2016
bors added a commit that referenced this pull request Jun 30, 2016
Rollup of 11 pull requests

- Successful merges: #34355, #34446, #34459, #34460, #34467, #34495, #34497, #34499, #34513, #34536, #34542
- Failed merges:
@bors bors merged commit 58955de into rust-lang:master Jun 30, 2016
@GuillaumeGomez GuillaumeGomez deleted the err-codes branch June 30, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants