Implementation of #34168 #34186
Implementation of #34168 #34186
Conversation
| @@ -465,6 +466,7 @@ impl LangString { | |||
| rust: true, // NB This used to be `notrust = false` | |||
| test_harness: false, | |||
| compile_fail: false, | |||
| error_codes: vec!(), | |||
GuillaumeGomez
force-pushed
the
err-code-check
branch
from
8fe5d9c
to
44060f3
Compare
|
Strange... We can't see my changes on here but we can on my branch: https://github.com/GuillaumeGomez/rust/blob/err-code-check/src/librustdoc/test.rs#L291 . So like we said when I saw @alexcrichton (I can finally say it haha), it seems it can be merged and then it'll be updated once the new error lib is out (keep me up to date on this @jonathandturner! :p). |
| @@ -493,7 +495,15 @@ impl LangString { | |||
| data.compile_fail = true; | |||
| seen_rust_tags = true; | |||
| data.no_run = true; | |||
| }, | |||
| } | |||
| x if allow_compile_fail && x.starts_with("E") && x.len() == 5 => { | |||
There was a problem hiding this comment.
I think this should be a separate 'feature gate'. Let's not just tie it to compile-fail but add another feature like check_error_codes.
GuillaumeGomez
force-pushed
the
err-code-check
branch
3 times, most recently
from
a3fa261
to
bdaf812
Compare
|
Updated. |
|
@alexcrichton: Up? |
| t("{.example .rust}", false, false, false, true, false, false); | ||
| t("{.test_harness .rust}", false, false, false, true, true, false); | ||
| // | error_codes | ||
| t("", false, false, false, true, false, false, Vec::new()); |
There was a problem hiding this comment.
Can't you leave these unchanged and always use vec![] in t? Or are there other calls I'm not seeing?
There was a problem hiding this comment.
No, you're absolutely right.
GuillaumeGomez
force-pushed
the
err-code-check
branch
from
bdaf812
to
ddfaf10
Compare
|
Updated. |
Implementation of #34168 r? @brson cc @alexcrichton cc @steveklabnik cc @jonathandturner I only updated `librustc_privacy/diagnostics.rs`, and I already found a case where the code doesn't throw the expected error code (E0448). Fixes #34168.
r? @brson
cc @alexcrichton
cc @steveklabnik
cc @jonathandturner
I only updated
librustc_privacy/diagnostics.rs, and I already found a case where the code doesn't throw the expected error code (E0448).Fixes #34168.