casting &[u8] to * const u8 doesn't work in const_eval
#33457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1117,6 +1117,10 @@ fn cast_const<'tcx>(tcx: &TyCtxt<'tcx>, val: ConstVal, ty: ty::Ty) -> CastResult | |||
| Float(f) => cast_const_float(tcx, f, ty), | |||
| Char(c) => cast_const_int(tcx, Infer(c as u64), ty), | |||
| Function(_) => Err(UnimplementedConstVal("casting fn pointers")), | |||
| ByteStr(_) => match ty.sty { | |||
| ty::TyRawPtr(_) => Err(ErrKind::UnimplementedConstVal("casting a bytestr to a raw ptr")), | |||
There was a problem hiding this comment.
How does this help? Wouldn't it still error?
EDIT: I think... I see? Can't be done in const_eval but is still constant.
There was a problem hiding this comment.
Yea, and the const_err lint ignores some kinds of errors, since there's no point in informing the user that const_eval can't evaluate it unless they try to use it in an array length or pattern.
|
@bors r+ |
|
📌 Commit d818a08 has been approved by |
|
|
|
And travis complains: |
|
@bors r- Until the tidy failure is fixed. |
oli-obk
force-pushed
the
const_err/cast_u8_ptr
branch
from
d818a08
to
7461e45
Compare
|
done |
|
@bors r+ |
|
📌 Commit 7461e45 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33452
r? @eddyb
cc @Ms2ger