Clarify std::fmt width docs w.r.t. dollar syntax and give example. #33258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 815987b has been approved by |
|
@bors: rollup |
|
one tip for making it less cryptic to read is to use a named parameter for the width. |
|
@bluss Interesting! From the syntax on that page, it is not apparent that names are allowed. I guess I'll make another change for that. |
|
(Procedure question: should I add a commit to this PR now that it is already approved, or make another PR once bors merged this one?) |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 29, 2016
Clarify std::fmt width docs w.r.t. dollar syntax and give example. The previous version only said "the `2$` syntax", which while introduced in the grammar is not very self-explanatory.
|
@birkenfeld it depends on the change, but with something small like this, a follow-up is fine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version only said "the
2$syntax", which while introduced in the grammar is not very self-explanatory.