Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add GitHub issue template #33164

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ contribute, and we appreciate all of them. This document is a bit long, so here'
links to the major sections:

* [Feature Requests](#feature-requests)
* [Bug Reports](#bug-reports)
* [Issue and Bug Reports](#issue-and-bug-reports)
* [The Build System](#the-build-system)
* [Pull Requests](#pull-requests)
* [Writing Documentation](#writing-documentation)
Expand All @@ -29,7 +29,7 @@ issue in the [RFCs repository](https://github.com/rust-lang/rfcs/issues/new)
rather than this one. New features and other significant language changes
must go through the RFC process.

## Bug Reports
## Issue and Bug Reports

While bugs are unfortunate, they're a reality in software. We can't fix what we
don't know about, so please report liberally. If you're not sure if something
Expand All @@ -46,25 +46,8 @@ extra credit. We won't mind if you accidentally file a duplicate report.

Opening an issue is as easy as following [this
link](https://github.com/rust-lang/rust/issues/new) and filling out the fields.
Here's a template that you can use to file a bug, though it's not necessary to
use it exactly:

<short summary of the bug>

I tried this code:

<code sample that causes the bug>

I expected to see this happen: <explanation>

Instead, this happened: <explanation>

## Meta

`rustc --version --verbose`:

Backtrace:

You'll notice we use [an issue template](ISSUE_TEMPLATE.md). It's advisable to
try to follow it, of course depending on the kind of issue you have.
All three components are important: what you did, what you expected, what
happened instead. Please include the output of `rustc --version --verbose`,
which includes important information about what platform you're on, what
Expand Down
45 changes: 45 additions & 0 deletions ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<!---
Hi! This template is here to help us collect optimal issue reports. Feel free to adapt it to your situation.
First, check whether the issue has already been reported. If so, please add this report to that issue thread. If not, proceed to file this new issue.
Next, please provide a one to four sentence summary of the issue. If you do your very best to be clear, concise and accurate here, other Rustaceans will be eager to assist. Also try to mention which GitHub labels this issue likely needs and/or what parts of Rust it relates to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m pretty sure people who are triaging the issues are much more suited for the task of triaging the issue compared to the average compiler user.

Most of them see compiler as a black box which gets fed source files in one end, and binaries, after some time, come out from another.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as summary goes, people already write a summary of sorts as the title, so, perhaps that’s good enough already?

--->

## Code sample
<!---
Please craft a minimal/simple and self-contained code sample that (re)produces the issue. If you create a formal test case straight away, that'll be even more helpful.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a formal test case? Is it a function with a #[test] attribute? If so, these cannot really test for ICEs for example. If that’s not the case, then you cannot expect users of the language to understand the test framework we use.

In addition to that, sometimes people can’t be bothered/don’t know how to to minimise their crate to a simple test case, so giving a link to the commit/branch/etc of a public project should also be an option.

Copy link
Contributor

@arielb1 arielb1 Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but a section of code that runs on playpen and produces the relevant behavior is very nice. That's how I try to report bugs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not disagree. It is pain to minimize other people’s crates to minimal test cases too. That being said see this.

--->
`main.rs`:
```rust

```

## Expected behavior
<!---
Please concisely explain what you expected instead of encountering of the issue. Check if it's helpful to refer to some relevant externalities.
* Could you refer to parts of official documentation, standards, comments in this codebase, etc.?
* Did/does the issue not occur with past/other versions?
* In case it's a correctness issue, then what's the relevant behavior of other implementations (for other languages)?.
* Are there very similar (perhaps informal) issue reports outside this issue tracker?
--->

## Actual behavior
<!---
Please paste here any human readable output in full. Important information can be in the initial details, so don't cut.
--->

## Meta
`rustc --version --verbose`:
```

```

## Backtrace
<!---
Finally, if you haven't shared it yet, reproduce the issue with your minimal example code and share the backtrace you obtained.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't shared it yet

What’s the “it” here?

This also should mention, that the section is optional and only relevant for compiler crashes.

On Windows, issue in PowerShell:
$env:RUST_BACKTRACE=1; &".\problematic_executable.exe"
On other platforms, issue in your shell:
env RUST_BACKTRACE=1 ./problematic_executable
--->
<!--- Thanks! --->