resolve: import resolution diagnostics #32849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| use bar::Foo; //~ ERROR There is no `Foo` in `bar` [E0432] |
There was a problem hiding this comment.
This error message used to include the nonsensical suggestion Did you mean to use Foo?
|
@bors r+ rollup |
|
📌 Commit 44ddaa2 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 10, 2016
…tics, r=eddyb resolve: import resolution diagnostics This improves the diagnostics for failing import resolutions (fixes rust-lang#32833). r? @eddyb
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 11, 2016
…tics, r=eddyb resolve: import resolution diagnostics This improves the diagnostics for failing import resolutions (fixes rust-lang#32833). r? @eddyb
bors
added a commit
that referenced
this pull request
Apr 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the diagnostics for failing import resolutions (fixes #32833).
r? @eddyb