Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Default for CondVar, Mutex and RwLock #32807

Closed
wants to merge 1 commit into from

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Apr 7, 2016

this fixes issue #31865

Note: The impls are unstable for now.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Apr 7, 2016

Looks related to #32785

@brson brson added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 7, 2016
@llogiq
Copy link
Contributor Author

llogiq commented Apr 8, 2016

It is related. And #32785 goes even further than this.

@durka
Copy link
Contributor

durka commented Apr 8, 2016

Note: The impls are unstable for now.

That doesn't work for trait impls, right?

@retep998
Copy link
Member

retep998 commented Apr 8, 2016

@durka trait impls are insta-stable. Marking them unstable doesn't really work.

@llogiq
Copy link
Contributor Author

llogiq commented Apr 8, 2016

OK then. I'll remove the unstable attrs if there is still interest.

@alexcrichton
Copy link
Member

Thanks for the PR @llogiq! I believe these are all covered by #32785, so I'm going to close in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants