Add comma after "For example" in tutorial #3223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make pull requests to incoming, not master. |
|
Thanks! I've rebased this and pushed to incoming. It will show up on master in a few days. |
|
Thanks! I'll make any future requests to incoming. |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
end expressions like return/continue/break with a semicolon
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Dec 17, 2023
Automatic Rustup
jaisnan
pushed a commit
to jaisnan/rust-dev
that referenced
this pull request
Jul 29, 2024
) CBMC's symbolic execution by default turns `while(true) {}` loops into `assume(false)` to counter trivial non-termination of symbolic execution. When unwinding assertions are enabled, however, we should report the non-termination of such loops. Resolves: rust-lang#2909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tutorial, my eye really expects to see a comma after "For example" in the first paragraph of # Closures. A web search seems to confirm that this is the common practice.
(It is so awesome to be reading a programming language tutorial where the examples are about playing Rock, Paper, Scissors and eating crayons.)