Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk: Distribute fewer TARGET_CRATES #32009

Merged
merged 1 commit into from
Mar 9, 2016

Conversation

alexcrichton
Copy link
Member

Right now everything in TARGET_CRATES is built by default for all non-fulldeps
tests and is distributed by default for all target standard library packages.
Currenly this includes a number of unstable crates which are rarely used such as
graphviz and rbml>

This commit trims down the set of TARGET_CRATES, moves a number of tests to
*-fulldeps as a result, and trims down the dependencies of libtest so we can
distribute fewer crates in the rust-std packages.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@sanxiyn
Copy link
Member

sanxiyn commented Mar 3, 2016

In Travis, run-pass/issue-11881.rs failed because it uses rbml.

@alexcrichton
Copy link
Member Author

Hm not sure how tests missed those, but should be all fixed now.

@brson
Copy link
Contributor

brson commented Mar 4, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 4, 2016

📌 Commit 4da9e9f has been approved by brson

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 4, 2016
Right now everything in TARGET_CRATES is built by default for all non-fulldeps
tests and is distributed by default for all target standard library packages.
Currenly this includes a number of unstable crates which are rarely used such as
`graphviz` and `rbml`>

This commit trims down the set of `TARGET_CRATES`, moves a number of tests to
`*-fulldeps` as a result, and trims down the dependencies of libtest so we can
distribute fewer crates in the `rust-std` packages.
@bors
Copy link
Collaborator

bors commented Mar 4, 2016

⌛ Testing commit 4da9e9f with merge 462eceb...

@bors
Copy link
Collaborator

bors commented Mar 4, 2016

💔 Test failed - auto-linux-musl-64-opt

Right now everything in TARGET_CRATES is built by default for all non-fulldeps
tests and is distributed by default for all target standard library packages.
Currenly this includes a number of unstable crates which are rarely used such as
`graphviz` and `rbml`>

This commit trims down the set of `TARGET_CRATES`, moves a number of tests to
`*-fulldeps` as a result, and trims down the dependencies of libtest so we can
distribute fewer crates in the `rust-std` packages.
@alexcrichton
Copy link
Member Author

@bors: r=brson 0d5cfd9

@bors
Copy link
Collaborator

bors commented Mar 8, 2016

⌛ Testing commit 0d5cfd9 with merge eabfc16...

bors added a commit that referenced this pull request Mar 8, 2016
mk: Distribute fewer TARGET_CRATES

Right now everything in TARGET_CRATES is built by default for all non-fulldeps
tests and is distributed by default for all target standard library packages.
Currenly this includes a number of unstable crates which are rarely used such as
`graphviz` and `rbml`>

This commit trims down the set of `TARGET_CRATES`, moves a number of tests to
`*-fulldeps` as a result, and trims down the dependencies of libtest so we can
distribute fewer crates in the `rust-std` packages.
@alexcrichton
Copy link
Member Author

All tests passed but bors didn't get around to merging, so merging manually.

@alexcrichton alexcrichton merged commit 0d5cfd9 into rust-lang:master Mar 9, 2016
@alexcrichton alexcrichton deleted the trim-fulldeps branch March 9, 2016 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants