-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking batch] don't glob-export syntax::abi
enums
#31485
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
While we're at it, should we also un-batch export |
cc @erickt heads up |
I'm creating a bunch of these PRs, then you can roll them up. Feels free to open an issue with checkboxes of things that should be done, in an order that your prefer. |
Nah, this works |
r+ on this one |
Should it have the ususal |
the [breaking-batch] is for batching up breaking libsyntax changes |
Is this a breaking change in the usual sense of |
Well, breaking libsyntax. Not sure if that qualifies as breaking; since many compiler changes break internals and we don't mark that as breaking either. |
I'll mark it. |
merged into #31487 |
r? @Manishearth