tweak colors for a11y #31054
Merged
tweak colors for a11y #31054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Struct color change. before:
after:
|
|
Traits. before:
after:
|
|
I think this is all I'd like to do for now. I'd like to land this, and then work on other stuff afterwards. |
|
I literally cannot see the difference :) |
|
Yeah, the first example is noticeable for me, but the other two are very very small. |
|
I support this change. The difference may be slight but it really helps readability in the long run. |
|
To be clear, I wasn't opposing the change. :) |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 23, 2016
I've been interested in the accessibility of Rustdoc's output, but never did anything about it. Today, I ran a tool, and it suggested adjusting some colors. Here's some screen shots. Before:  After:  As you can see, the link text is just a _shade_ darker. Browsable: http://www.steveklabnik.com/rust-a11y-doc-testing/doc/std/
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 23, 2016
I've been interested in the accessibility of Rustdoc's output, but never did anything about it. Today, I ran a tool, and it suggested adjusting some colors. Here's some screen shots. Before:  After:  As you can see, the link text is just a _shade_ darker. Browsable: http://www.steveklabnik.com/rust-a11y-doc-testing/doc/std/
bors
added a commit
that referenced
this pull request
Jan 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been interested in the accessibility of Rustdoc's output, but never did anything about it. Today, I ran a tool, and it suggested adjusting some colors.
Here's some screen shots. Before:
After:
As you can see, the link text is just a shade darker.
Browsable: http://www.steveklabnik.com/rust-a11y-doc-testing/doc/std/