Add new help messages for E0425 #30584
Conversation
|
@GuillaumeGomez where are the tests of the new messages you are adding here? see e.g. pnkfelix@6946995 from #30413 |
GuillaumeGomez
force-pushed
the
new_handles
branch
from
f78e447 to
4f5f6a3
Compare
|
Tests have been added. |
| } | ||
| } else { | ||
| help_msg = format!("Module `{module}` cannot be used as an object!", |
There was a problem hiding this comment.
hmm, do we used the terminology "used as an object" elsewhere? (That is supposed to mean that its been used as the receiver in a method call or field lookup, right?)
On the one hand, your phrasing is succinct. But on the other hand, I'm not sure everyone will understand what it means ...
There was a problem hiding this comment.
oh, duh, I should have looked at the test!
There was a problem hiding this comment.
Okay, so I don't like the phrasing "used as an object" here.
I would instead say something like "Module {module} cannot be passed around as a first-class value."
(except that may be a bit long winded... maybe just "Module {module} cannot be the value of an expression" ?)
GuillaumeGomez
force-pushed
the
new_handles
branch
from
4f5f6a3 to
73bcb04
Compare
|
I changed the message, tell me if it fits better what you have in mind. |
GuillaumeGomez
force-pushed
the
new_handles
branch
from
73bcb04 to
c078769
Compare
|
@GuillaumeGomez thanks, sorry for the slow processing of the PR! |
|
@bors rollup+ |
|
@bors rollup |
Last part of #30413.
r? @pnkfelix