Add is_empty() for PathBuf (fixes #30259), Overide methods in iterator implementation for EscapeDefault (#24214), Add help note for E0514, Improve internal docs in librustc #30520

ticki · 2015-12-22T10:08:53Z

rust-highfive · 2015-12-22T10:09:07Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Remove tabs

Lots of cruft to remove!

It's been awhile since we last updated jemalloc, and there's likely some bugs that have been fixed since the last version we're using, so let's try to update again.

Checks for a `10.` prefix on the subfolder Signed-off-by: Peter Atashian <retep998@gmail.com>

All these definitions can now be written in Rust, so do so!

Remove tabs

jonas-schievink · 2015-12-22T11:46:01Z

src/compiler-rt

@@ -1 +1 @@
-Subproject commit b6087e82ba1384c4af3adf2dc68e92316f0d4caf


Looks like a git accident

I've updated the submodules.

bluss · 2015-12-22T14:30:58Z

src/libstd/path.rs

+    /// ```
+    #[unstable(feature = "path_extras", reason = "recently added", issue = "30259")]
+    pub fn is_empty(&self) -> bool {
+        if let Some(b) = self.inner.to_bytes() {


I think it's better to use os_str_as_u8_slice and check if it is empty. It's not fallible and it's simple.

@bluss Check out the latest commit.

…ough the unicode validity checking on Windows

ticki · 2015-12-22T15:06:04Z

I refactored this patch a bit, by adding a is_empty() method to OsStr, and using it in Path, this gives a minor speed-up on Windows.

bluss · 2015-12-22T17:36:24Z

yep, travis failed to build jemalloc for some reason (so not related to this PR).

Can you put the information in the PR title into the PR message itself? Probably give the PR a shorter title too.

Adding OsStr::is_empty() seems logical, and Path::is_empty looks good too

alexcrichton · 2015-12-22T18:38:41Z

It looks like there's quite a few changes going on here, namely:

Lots of submodules updates -- can these all be reverted? It looks like they may be intentional?
Specialization of EscapeDefault iterator methods -- updated, but no tests have been added. Perhaps this could be separated to a different PR?
Various formatting/documentation here and there -- could this be separated to a different PR?
Updating a compiler message -- can this also be separated?
Addition of new APIs on Path and OsString -- can this PR be focused on these additions?

This is touching quite a few components which will be easier to review if split apart (as different reviewers are most applicable for the various areas here).

ticki · 2015-12-22T18:51:27Z

Lots of submodules updates -- can these all be reverted? It looks like they may be intentional?

Right, I'll downgrade them.

Specialization of EscapeDefault iterator methods -- updated, but no tests have been added. Perhaps this could be separated to a different PR?

Yeah, will add some tests.

Various formatting/documentation here and there -- could this be separated to a different PR?

Updating a compiler message -- can this also be separated?

Addition of new APIs on Path and OsString -- can this PR be focused on these additions?

Yeah, I'll fix the points above and then seperate them into multiple PRs. Sorry for that.

ticki · 2015-12-22T19:02:44Z

The submodules are now downgraded.

Fix introduced error

bluss · 2015-12-23T08:15:32Z

This is somewhere in the log.


failures:

---- path::Path::is_empty_0 stdout ----
    <anon>:8:19: 8:29 error: use of unstable library feature 'os_extras': recently added (see issue #30259)
<anon>:8     assert!(!path.is_empty());
                           ^~~~~~~~~~
<anon>:8:5: 8:31 note: in this expansion of assert! (defined in <std macros>)
<anon>:8:19: 8:29 help: add #![feature(os_extras)] to the crate attributes to enable
error: aborting due to previous error
thread 'path::Path::is_empty_0' panicked at 'Box<Any>', src/libsyntax/errors/mod.rs:269


failures:
    path::Path::is_empty_0

ticki · 2015-12-23T08:23:29Z

Yeah, I realized that I forgot to push the latest commit.

nagisa · 2015-12-29T19:50:25Z

Still seems to be a mess?

ticki · 2015-12-29T20:45:57Z

Yes. I'll organize this better when I get time.

ticki · 2015-12-29T21:46:11Z

I've now parted this into multiple PRs. Will close.

Part of #30520. Completes #24214

ticki added 7 commits December 21, 2015 22:24

Internal documentation and code style

0bd458d

Add help for E0514

a503c80

Add is_empty() for PathBuf, fix rust-lang#30259

64aea50

Move the is_empty method to Path instead

92ae54c

Tests

3324a14

Overide methods in iterator implementation for EscapeDefault, see rus…

99ee087

…t-lang#24214

Merge branch 'master' of https://github.com/rust-lang/rust into HEAD

47690f2

rust-highfive assigned nikomatsakis Dec 22, 2015

Fix style nitpicks from travis

0435a46

Remove tabs

ticki force-pushed the master branch from 49c454c to 0435a46 Compare December 22, 2015 10:26

Ms2ger and others added 6 commits December 22, 2015 12:40

Stop re-exporting the ast::BindingMode variants.

ba511f2

Register new snapshots

7e487b4

Lots of cruft to remove!

std: Update jemalloc version

ed237e5

It's been awhile since we last updated jemalloc, and there's likely some bugs that have been fixed since the last version we're using, so let's try to update again.

Fix Universal CRT detection on weird setups

c0321ed

Checks for a `10.` prefix on the subfolder Signed-off-by: Peter Atashian <retep998@gmail.com>

std: Remove rust_builtin C support library

2062fd3

All these definitions can now be written in Rust, so do so!

Fix style nitpicks from travis

f89581e

Remove tabs

jonas-schievink reviewed Dec 22, 2015
View reviewed changes

ticki added 2 commits December 22, 2015 15:17

Update submodules

05df049

Merge branch 'master' of github.com:Ticki/rust into HEAD

d26fd3e

bluss reviewed Dec 22, 2015
View reviewed changes

Add is_empty to OsStr, rename path_extras to os_extras, don\'t go thr…

7db394a

…ough the unicode validity checking on Windows

ticki force-pushed the master branch 2 times, most recently from 66cb5a6 to 7db394a Compare December 22, 2015 15:02

Downgrade submodules

1448ce9

ticki added 5 commits December 22, 2015 20:13

Fix introduced error

cceeb8f

Fix introduced error

d410e67

Merge branch 'master' of github.com:Ticki/rust into HEAD

17ff466

Fix introduced error

7c59d0c

Fix introduced error

Merge branch 'master' of github.com:Ticki/rust into HEAD

b2745f3

ticki force-pushed the master branch from 1ba4a2e to 4e369d2 Compare December 22, 2015 19:46

Complete the tests

efbd47f

ticki force-pushed the master branch from 0eda012 to efbd47f Compare December 22, 2015 20:54

ticki added 3 commits December 22, 2015 21:58

Add issue to attr

5573713

Documentation

6bd9fe1

Remove unused variables

644f258

Added features

1f9941f

ticki force-pushed the master branch from 262ff21 to 1f9941f Compare December 23, 2015 14:57

This was referenced Dec 29, 2015

Improve internal docs and code style in librustc/front #30621

Closed

Add help for E0514 #30622

Closed

is_empty for OsStr #30623

Closed

Iterator specialization for EscapeDefaults #30624

Merged

ticki closed this Dec 29, 2015

bors added a commit that referenced this pull request Jan 16, 2016

Auto merge of #30624 - Ticki:specialization, r=alexcrichton

1f516dc

Part of #30520. Completes #24214

ranma42 mentioned this pull request Jan 20, 2016

Implement nth, count, and last for EscapeUnicode #31049

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add is_empty() for PathBuf (fixes #30259), Overide methods in iterator implementation for EscapeDefault (#24214), Add help note for E0514, Improve internal docs in librustc #30520

Add is_empty() for PathBuf (fixes #30259), Overide methods in iterator implementation for EscapeDefault (#24214), Add help note for E0514, Improve internal docs in librustc #30520

ticki commented Dec 22, 2015

rust-highfive commented Dec 22, 2015

jonas-schievink Dec 22, 2015

ticki Dec 22, 2015

bluss Dec 22, 2015

ticki Dec 22, 2015

ticki commented Dec 22, 2015

bluss commented Dec 22, 2015

alexcrichton commented Dec 22, 2015

ticki commented Dec 22, 2015

ticki commented Dec 22, 2015

bluss commented Dec 23, 2015

ticki commented Dec 23, 2015

nagisa commented Dec 29, 2015

ticki commented Dec 29, 2015

ticki commented Dec 29, 2015

		@@ -1 +1 @@
		Subproject commit b6087e82ba1384c4af3adf2dc68e92316f0d4caf

Add is_empty() for PathBuf (fixes #30259), Overide methods in iterator implementation for EscapeDefault (#24214), Add help note for E0514, Improve internal docs in librustc #30520

Add is_empty() for PathBuf (fixes #30259), Overide methods in iterator implementation for EscapeDefault (#24214), Add help note for E0514, Improve internal docs in librustc #30520

Conversation

ticki commented Dec 22, 2015

rust-highfive commented Dec 22, 2015

jonas-schievink Dec 22, 2015

Choose a reason for hiding this comment

ticki Dec 22, 2015

Choose a reason for hiding this comment

bluss Dec 22, 2015

Choose a reason for hiding this comment

ticki Dec 22, 2015

Choose a reason for hiding this comment

ticki commented Dec 22, 2015

bluss commented Dec 22, 2015

alexcrichton commented Dec 22, 2015

ticki commented Dec 22, 2015

ticki commented Dec 22, 2015

bluss commented Dec 23, 2015

ticki commented Dec 23, 2015

nagisa commented Dec 29, 2015

ticki commented Dec 29, 2015

ticki commented Dec 29, 2015