Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import ParseResult's variants in dec2flt. #30435

Merged
merged 1 commit into from
Dec 19, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 17, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@hanna-kruppe
Copy link
Contributor

I have no strong opinion on this, but I do wonder: is it the established style to not import the variants? And if so, is it established by virtue of being done that way everywhere or is it a conscious decision that's documented somewhere?

@alexcrichton
Copy link
Member

I think it's not unheard of to import variants in some contexts (e.g. if they're used on basically every line in the file) but because they're not imported by default it's more idiomatic to access them through the enum itself (e.g. that affects how the variants themselves are named).

@bors: r+ 1e44ece

@bors
Copy link
Contributor

bors commented Dec 19, 2015

⌛ Testing commit 1e44ece with merge d8cc67f...

@bors bors merged commit 1e44ece into rust-lang:master Dec 19, 2015
@Ms2ger Ms2ger deleted the ParseResult branch December 30, 2015 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants