Improve detection of unused imports (fixes #30078) #30325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
|
Travis failed because of new unused_imports warnings. |
jseyfried
force-pushed
the
fixes_30078
branch
4 times, most recently
from
797acf3
to
9a88b11
Compare
|
Awesome! Could you also expand the commit message to include information like:
r? @nrc (looking at other resolve changes lately as well) |
jseyfried
force-pushed
the
fixes_30078
branch
9 times, most recently
from
3651c06
to
83dde14
Compare
|
r+ with the changes to the commit message that @alexcrichton requested |
|
Eh, isn't the commit message already changed? |
|
@bors: r+ (ah yeah, I think I needed to refresh my browser) |
|
📌 Commit 83dde14 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Dec 16, 2015
This fixes a bug in which unused imports can get wrongly marked as used when checking for unused qualifications in `resolve_path` (issue rust-lang#30078), and it removes unused imports that were previously undetected because of the bug.
|
☔ The latest upstream changes (presumably #30300) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfried
changed the title
…ed as used when checking for unused qualifications in resolve_path (fixes rust-lang#30078)
jseyfried
force-pushed
the
fixes_30078
branch
from
83dde14
to
ba20a86
Compare
|
@nrc rebased |
|
@bors: r+ |
|
📌 Commit ba20a86 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 17, 2015
This fixes a bug in which unused imports can get wrongly marked as used when checking for unused qualifications in `resolve_path` (issue #30078), and it removes unused imports that were previously undetected because of the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in which unused imports can get wrongly marked as used when checking for unused qualifications in
resolve_path(issue #30078), and it removes unused imports that were previously undetected because of the bug.