book: Add documentation on custom allocators #28869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| let a = Box::new(4); // allocates from jemalloc | ||
| println!("{}", a); | ||
| } | ||
| # fn main() {} |
There was a problem hiding this comment.
If this is declared to be a dylib, why is main present?
There was a problem hiding this comment.
IIRC Rustdoc has issues here, basically
There was a problem hiding this comment.
Ah yeah this is just needed to appears rustdoc --test, the dylib above if for readers and the fn main is needed because rustdoc overrides the crate_type in the source with a manual specification.
|
🤘 ❤️ |
| decision can be left up the compiler. | ||
|
|
||
| Dynamic and static libraries, however, will use `alloc_system` by default. Here | ||
| Rust is typically a "guest" in another application or another world where it |
|
Looks great to me! Just some nits. |
alexcrichton
force-pushed
the
allocator-dox
branch
from
105cb33 to
9a38747
Compare
|
re-r? @steveklabnik |
| // Our system allocator will use the in-tree libc crate for FFI bindings. Note | ||
| // that currently the external (crates.io) libc cannot be used because it links | ||
| // to the standard library (e.g. `#![no_std]` isn't stable yet), so that's why | ||
| // this specifically requires the in-tree version. |
|
@bors: r+ rollup |
|
📌 Commit 9a38747 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 7, 2015
…klabnik This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 7, 2015
…klabnik This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
|
@bors: r- |
alexcrichton
force-pushed
the
allocator-dox
branch
from
9a38747 to
994a577
Compare
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 8, 2015
…klabnik This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
|
Still looks like it's failing http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/1646/steps/test/logs/stdio |
|
@bors: r- |
This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
alexcrichton
force-pushed
the
allocator-dox
branch
from
994a577 to
abe7874
Compare
bors
added a commit
that referenced
this pull request
Oct 9, 2015
This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
|
🎊 On Fri, Oct 9, 2015 at 4:53 AM, bors notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a chapter to the nightly section of the book on leveraging and
implementing the
#![allocator]attribute to write custom allocators as well asexplaining the current situation with allocators.