Replace Idents with Names in HIR (Part 1)
#28535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #28429) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me with the minor fold change |
PathSegment, PatIdent, ExprWhile, ExprLoop, ExprBreak and ExprAgain - they need Idents for resolve
|
@nrc |
|
@bors: r+ |
|
📌 Commit 0af8e47 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 23, 2015
Part of #6993 This patch replaces `Ident`s with `Name`s in data structures of HIR and updates the dependent crates to compile and pass `make check`. Some HIR structures still use `Ident`s, namely `PathSegment`, `PatIdent`, `ExprWhile`, `ExprLoop`, `ExprBreak` and `ExprAgain`, they need them for resolve (but `PathSegment` is special, see #6993 (comment)). r? @nrc
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6993
This patch replaces
Idents withNames in data structures of HIR and updates the dependent crates to compile and passmake check.Some HIR structures still use
Idents, namelyPathSegment,PatIdent,ExprWhile,ExprLoop,ExprBreakandExprAgain, they need them for resolve (butPathSegmentis special, see #6993 (comment)).r? @nrc