Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #28529

Merged
merged 10 commits into from
Sep 20, 2015
Merged

Rollup of 5 pull requests #28529

merged 10 commits into from
Sep 20, 2015

Conversation

Manishearth
Copy link
Member

johncf and others added 10 commits September 19, 2015 21:11
@johncf
trpl: Improve clarity in Concurrency
a0f214e
@apasel422
Feature-gate #[no_debug] and #[omit_gdb_pretty_printer_section]
6fa0ff2 
Closes rust-lang#28091.
@Wallacoloo
Fix "more more" typo
a35f1b2
@Manishearth
Move tts instead of cloning in expansion
8aef16c
@Manishearth
Don't recommend const fns on a stable build without a note about nigh…
dcf49b5 
…tlies

Fixes rust-lang#28490
@Manishearth
Rollup merge of rust-lang#28463 - critiqjo:book-concurrency, r=stevek…
d007eb6 
…labnik

Fixes rust-lang#28458

Details about `Arc` may be too soon to be described together with `Sync`... Tell me what you think.

r? @steveklabnik
@Manishearth
Rollup merge of rust-lang#28507 - Manishearth:const-stable, r=alexcri…
dc377b2 
…chton

Fixes rust-lang#28490

cc rust-lang#24111
@Manishearth
Rollup merge of rust-lang#28522 - apasel422:issue-28091, r=alexcrichton
fb690c7 
Closes rust-lang#28091.

r? @huonw
@Manishearth
Rollup merge of rust-lang#28525 - Wallacoloo:book-4.8-double-more, r=…
8f8fe81 
…steveklabnik

This is a simple grammar fix in which the previous author accidentally repeated a word when (s)he shouldn't have.
@Manishearth
Rollup merge of rust-lang#28526 - Manishearth:expand-clone, r=eddyb
d7ec69a 
This reduces some clones of `Vec`s. These are not deep copies since the
token tree is made using `Rc`s, so this won't be a major improvement.

r? @eddyb
@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member Author

@bors r+ p=20

@bors
Copy link
Contributor

bors commented Sep 20, 2015

📌 Commit d7ec69a has been approved by Manishearth

@Manishearth Manishearth assigned Manishearth and unassigned nrc Sep 20, 2015
bors added a commit that referenced this pull request Sep 20, 2015
@bors
Auto merge of #28529 - Manishearth:rollup, r=Manishearth
25aaeb4 
- Successful merges: #28463, #28507, #28522, #28525, #28526
- Failed merges:
@bors
Copy link
Contributor

bors commented Sep 20, 2015

⌛ Testing commit d7ec69a with merge 25aaeb4...

@bors
Copy link
Contributor

bors commented Sep 20, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit d7ec69a into rust-lang:master Sep 20, 2015
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
rollup A PR which is a rollup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Manishearth @rust-highfive @bors @nrc @Centril @johncf @apasel422 @Wallacoloo