Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TARPL to the Rustonomicon #27444

Merged
merged 1 commit into from
Aug 4, 2015
Merged

Rename TARPL to the Rustonomicon #27444

merged 1 commit into from
Aug 4, 2015

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Jul 31, 2015

Closes #27412

r? @brson

@Gankra
Copy link
Contributor Author

Gankra commented Jul 31, 2015

This is also the final resolution of #13871

@huonw
Copy link
Member

huonw commented Jul 31, 2015

I think that Rustonomicon sounds slightly better.

@steveklabnik
Copy link
Member

👍 to o

Sent from my iPhone

On Jul 31, 2015, at 14:23, Huon Wilson notifications@github.com wrote:

I think that Rustonomicon sounds slightly better.


Reply to this email directly or view it on GitHub.

@Gankra Gankra changed the title Rename TARPL to the Rustinomicon Rename TARPL to the Rustonomicon Jul 31, 2015
@killercup
Copy link
Member

While The Advanced Rust Programming Language sounds like a serious manual full of technical details and concepts, The Rustonomicon will prepare the reader for @gankro's cheerful writing! 😄

@nham
Copy link
Contributor

nham commented Jul 31, 2015

With this change, I suppose the book will have to be translated into medieval Arabic. Many spells will need to be added as well, but this can all be work for future PRs.

@sweber6106
Copy link

"The Advanced Rust Programming Language" makes it sound like there was a prior, not-so-advanced language. "The Rust Programming Language" is fine and tight. Add a sub-title if absolutely required.

@bors
Copy link
Contributor

bors commented Aug 1, 2015

☔ The latest upstream changes (presumably #27453) made this pull request unmergeable. Please resolve the merge conflicts.

@jroesch
Copy link
Member

jroesch commented Aug 1, 2015

👍

$(Q)rm -rf doc/adv-book
$(Q)$(RUSTBOOK) build $(S)src/doc/tarpl doc/adv-book
$(Q)rm -rf doc/nomicon
$(Q)$(RUSTBOOK) build $(S)src/doc/nomicon doc/nomicon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translates to the ultimate URL of the doc and I wonder if 'doc/rustonomicon' would be clearer, more guessable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -- I personally felt rustonomicon was a bit too long, and also expect people to mess up the vowel after rust. I also don't expect much cold-typing of the URL. just autocompleteing/linking/bookmark/search.

@brson
Copy link
Contributor

brson commented Aug 2, 2015

Well, I like this a lot. It has a lot of branding possibilities in physical publication, and it has a Rust-rich backstory with the Lovecraft connection. It does nothing at all to stem the criticism about the casual tone in our docs, but I'm ok doubling down on the whimsy for these docs (and the casual reputation of our docs is probably more good than bad). The reference and other books can be expanded in a more straightforward technical style.

(As a recall Gankro suggesting once we might consider styling it differently to suggest the dark knowledge within, but that can be done later).

@Gankra
Copy link
Contributor Author

Gankra commented Aug 3, 2015

(rebased)

@Gankra
Copy link
Contributor Author

Gankra commented Aug 3, 2015

Per offline discussion I've added a subtitle for SEO/clarity/auto-complete purposes. I will be submitting a patch to our nginx config to make adv-book/rustonomicon/rustinomicon redirct to nomicon

@bors r=brson

@bors
Copy link
Contributor

bors commented Aug 3, 2015

📌 Commit ca902dd has been approved by brson

@edunham
Copy link
Member

edunham commented Aug 3, 2015

Summarizing IRC discussion this morning in #rust-internals about the name:

  • Concerns about the name being difficult to spell and remember for non-Lovecraft fans will be addressed by adding the subtitle "The Dark Arts of Advanced and Unsafe Rust Programming"
  • Because Rustdoc doesn't exactly support subtitles, the title in the pages will be "Rustonomicon: The Dark Arts of Advanced and Unsafe Rust Programming".
  • Since the name is hard to spell, the docs will live at the /nomicon URL and /rustonomicon, /rustinomicon, and /adv-book will all redirect to /nomicon. I'll add these redirects once the PR lands.

@Gankra
Copy link
Contributor Author

Gankra commented Aug 3, 2015

@edunham I actually settled on an <h4> for the subtitle, but otherwise 👍

@bors
Copy link
Contributor

bors commented Aug 4, 2015

⌛ Testing commit ca902dd with merge ce719ee...

@bors
Copy link
Contributor

bors commented Aug 4, 2015

💔 Test failed - auto-mac-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Aug 3, 2015 at 8:50 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/6009


Reply to this email directly or view it on GitHub
#27444 (comment).

bors added a commit that referenced this pull request Aug 4, 2015
@bors
Copy link
Contributor

bors commented Aug 4, 2015

⌛ Testing commit ca902dd with merge 7a7789d...

@bors bors merged commit ca902dd into rust-lang:master Aug 4, 2015
@bors bors mentioned this pull request Aug 4, 2015
@pnkfelix
Copy link
Member

pnkfelix commented Aug 5, 2015

\(;,;)/

@strega-nil
Copy link
Contributor

You've met with a terrible fate, haven't you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet