Allow ?Sized types in Rc’s impls of {Partial,}{Ord,Eq} and Borrow
#25460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ rollup |
|
📌 Commit cb56237 has been approved by |
| fn cmp(&self, other: &Rc<T>) -> Ordering { (**self).cmp(&**other) } | ||
| } | ||
| #[stable(feature = "rust1", since = "1.0.0")] | ||
| #[cfg(not(stage0))] | ||
| impl<T: Ord> Ord for Rc<T> { |
There was a problem hiding this comment.
Perhaps a forgotten ?Sized annotation here?
There was a problem hiding this comment.
Nice catch, thanks. Fixed.
bors
added a commit
that referenced
this pull request
May 16, 2015
Most of `Rc`’s trait implementations were DST-ified in #24619, but not these ones.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of
Rc’s trait implementations were DST-ified in #24619, but not these ones.