Proper expansion info for for loops and other compiler expanded language items #25318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
changed the title
|
Why do we want expansion info here? |
|
Because otherwise the spans are lies - we get a span for parts of the expansions of the for loop which are not what the span is for - i.e., a span for a type which is actually a value in the source. Furthermore, without expansion info you can't tell that the code has been expanded - a tool should assume that the expanded source is the same as the pre-expansion source, which it isn't. |
bors
added a commit
that referenced
this pull request
May 13, 2015
| } | ||
|
|
||
| ast::ExprClosure(capture_clause, fn_decl, block) => { | ||
| push_compiler_expansion(fld, span, "closure expansion"); |
There was a problem hiding this comment.
Came here from git blame, was this change accidental?
Closures are not expanded differently from free functions, so they shouldn't require custom expansion stacks.
All that does is pollute diagnostic output IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @sfackler