-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error-handling.md #25242
Update error-handling.md #25242
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
@@ -214,7 +214,7 @@ we can use the `unwrap()` method: | |||
io::stdin().read_line(&mut buffer).unwrap(); | |||
``` | |||
|
|||
`unwrap()` will `panic!` if the `Option` is `None`. This basically says "Give | |||
`unwrap()` will `panic!` if the `Result` is `None`. This basically says "Give |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it must be: Result
is Err
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willem66745 So it is, I update the pull request.
Fix two typos while `io::stdin().read_line()` returns `Result` actually Signed-off-by: acgtyrant <acgtyrant@gmail.com>
@bors: r+ rollup |
📌 Commit fa3fd81 has been approved by |
Fix a typo while `io::stdin().read_line()` returns `Result` actually
⌛ Testing commit fa3fd81 with merge 86fc513... |
Fix a typo while `io::stdin().read_line()` returns `Result` actually
Fix a typo while `io::stdin().read_line()` returns `Result` actually
⛄ The build was interrupted to prioritize another pull request. |
Fix a typo while
io::stdin().read_line()
returnsResult
actually