1.0 release notes and authors updates #25196
Conversation
brson
added
the
beta-nominated
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| * [Lifetime shadowing is an error][lt]. | ||
| * [`Send` no longer implies `'static`][send-rfc], which made possible | ||
| the [`thread::scoped` API][scoped]. Scoped threads can borrow data | ||
| from their parent's stack frame -- safely! |
|
I noticed at least one duplicate in the AUTHORS. There may be others: |
|
I'm in the list twice: You can remove the second one if you'd like. |
|
There are 2 duplicated names (Alfie John and Jakub Wieczorek with different email addresses). I don't know if it's intentional or not, so I haven't tried to make a PR or anything. I found 23 duplicate email addresses (names are different, some use their middle name, some are 'handles'). |
|
@brson, I made a PR on your repo that removes the duplicates in what I think is a sane way to go about it. |
|
@cjwelborn Thanks! Merged. |
|
@tshepang Under the normal release schedule, the beta of 4 weeks ago would not have its own release notes - those would be the release notes of the next stable release. So the thinking was to combine them to provide the full picture of what happened recently. The amount of new work that went into 1.0 this cycle was actually pretty small... Beta's are not 'releases' even though we treated the last one as such. |
|
Looks like I'm in there twice. Thanks @cjwelborn, but my preferred email for all things Rust is alfie@alfie.wtf :) |
|
@alfiedotwtf, sorry about that. I'm glad you caught it before it was finalized. |
|
D'oh! Looks like I had my email as my name in gitconfig. Any chance Sorry about that... |
|
If you're taking these last minute comments... |
| [new `dropck`][dropck]. This change is a major reduction in unsafe | ||
| code. | ||
| * Trait coherence was [revised again][fundamental], this time with an | ||
| eye toward API evolution over time. |
|
Could you update "Russell rpjohnst@gmail.com" to "Russell Johnston rpjohnst@gmail.com"? |
|
Can someone move John Kleint out of my names? |
| without breaking downsteam code. | ||
| * Digits of binary and octal literals are [lexed more eagerly][lex] to | ||
| improve error messages and macro behavior. For example, `0b1234` is | ||
| now lexed as `0b1234` instead of two tokens, `0b1` and `34`. |
|
Not sure why I decided to abbreviate my name. Could you change 'Ben S' to 'Ben Sago'? Ta |
|
Please change So much thanks to the Rust team for doing this! 💗 |
|
@ogham "Ben S" is the name associated with your github profile: https://github.com/ogham |
|
@brson Is it any kind of code contribution that counts (ie commits in master)? |
|
Could you change "TyOverby" to "Ty Overby"? Thanks! |
|
@laumann yes, any commit! |
|
Could you please change "blackbeam" to "Anatoly Ikorsky"? |
|
@laumann, oh, I apologise because I realise I may have misspoke: this is the first release where the release isn't from the master branch, so some recent contributions may not be in it (I'm unsure if that commit is). |
|
@laumann Anybody with commits to this repo. |
brson
force-pushed
the
relnotes
branch
4 times, most recently
from
851ade0 to
5c26a7b
Compare
|
Updated with all comments addressed (I think) except @Zoxc's. |
| bar`, and Cargo now automatically translates "-" in *package* names | ||
| to underscore for the crate name. | ||
| * [Lifetime shadowing is an error][lt]. | ||
| * [`Send` no longer implies `'static`][send-rfc], which made possible |
There was a problem hiding this comment.
, which made possible is a half sentence hanging here.
|
@brson My complaint was addressed atleast. I'm no longer listed twice. |
| Version 1.0.0-beta (April 2015) | ||
| ------------------------------------- | ||
|
|
||
| * ~1100 changes, numerous bugfixes |
There was a problem hiding this comment.
am curious why remove change count
There was a problem hiding this comment.
Thanks for mentioning me!
This is me:
Heejong Ahn <heejongahn@gmail.com poga.bahamut@gmail.com>
p.s) To be frank, it's my first (and misc) open-source contribution and I
don't know what's really going on here so I just mocked what Poga's mail..
Plz let me know if I've done anything wrong.
2015-05-11 14:28 GMT+09:00 Tshepang Lekhonkhobe notifications@github.com:
In RELEASES.md
#25196 (comment):@@ -1,79 +1,140 @@
-Version 1.0.0-beta (April 2015)
-* ~1100 changes, numerous bugfixes
am curious why remove change count
—
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/rust/pull/25196/files#r30013677.
|
I am: If it needs to be ascii, just use 'z' instead of 'ž'. ps. Thanks everyone for an awesome language :) |
|
If spellchecking is considered relevant contribution, please add due to #24812 |
|
If writing a postponed RFC is considered as a relevant contribution (maybe not, but I wanted to ask anyway :p), is it possible to add Due to rust-lang/rfcs#257 |
|
r=me whenever this is ready @brson |
|
@bors: r=alexcrichton |
|
📌 Commit 94caeb3 has been approved by |
|
I've already picked this into beta, so setting tag to beta-accepted |
brson
added
beta-accepted
|
I checked the authors file. It contains an old spam-infested email address, which is fine. Now somehow my github email appears in the 1.0 announcement, and right on queue I get a bunch of phishing emails. How'd that happen? I'm now going to have to replace the github email... don't put the new one in blog posts please. |
|
@dhardy that's security through obscurity. All it takes is a bot to clone one of your repo to see your email address. Consider using temporary aliases for anything public facing. |
That's precisely what it is, and mostly my system works (it seems bots are not in the habit of cloning repos). I only get spam on the gmail address and if anyone emails me there, they get an "out-of-office" reply notifying them that I don't read it frequently. |
cc @aturon