Make UnsafeCell, RefCell, Mutex, and RwLock accept DSTs
#24737
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Would this be a backward-compatible change? In other words, is it an argument for cherry-picking #24619 into beta? |
|
It allows strictly more programs, IIRC, and so is backwards compatible. |
|
Doing |
|
@bors r+ |
|
📌 Commit 17876ec has been approved by |
This + DST coercions (#24619) would allow code like `Rc<RefCell<Box<Trait>>>` to be simplified to `Rc<RefCell<Trait>>`.
|
💔 Test failed - auto-mac-64-opt |
|
Sorry, I mustn’t have run the tests thoroughly enough. It should be fixed now. r? |
|
⌛ Testing commit aed293a with merge 4389a3b... |
|
💔 Test failed - auto-mac-64-opt |
This + DST coercions (rust-lang#24619) would allow code like `Rc<RefCell<Box<Trait>>>` to be simplified to `Rc<RefCell<Trait>>`.
|
Ugh, I somehow missed that one. |
|
⌛ Testing commit 57d8289 with merge c512850... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
The failure doesn’t seem related (and doesn’t occur locally). Is this a known spurious failure? |
|
@bors: retry On Sat, May 2, 2015 at 1:55 AM, P1start notifications@github.com wrote:
|
|
⌛ Testing commit 57d8289 with merge 1fb4ecc... |
|
💔 Test failed - auto-linux-64-opt |
|
@bors: retry On Sun, May 3, 2015 at 7:06 AM, bors notifications@github.com wrote:
|
This + DST coercions (#24619) would allow code like `Rc<RefCell<Box<Trait>>>` to be simplified to `Rc<RefCell<Trait>>`.
This + DST coercions (#24619) would allow code like
Rc<RefCell<Box<Trait>>>to be simplified toRc<RefCell<Trait>>.