-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustdoc: ignore deref-inherited static methods #24657
Conversation
I am not sure on how to test this. At this moment I only know that it compiles... |
Could you modify the existing tests for #19190 in conjunction with the Also, could you upload a copy of the docs so they could be manually verified as well? |
It seems that my changes aren't entirely correct. Hiding static methods works if the target type is a primitive (in this case btw, I used |
I think you may want to modify the rendering function instead of the inlining functions as local Also yeah using |
Thanks for your feedback! I have updated the PR and uploaded the documentation to http://aochagavia.github.io/rust/index.html |
@bors: r- er actually, could you squash the commits and a more descriptive commit message about this fix? Unfortunately |
☔ The latest upstream changes (presumably #23606) made this pull request unmergeable. Please resolve the merge conflicts. |
Ping? |
Sorry, I won't have time to resolve the merge conflicts and test the patch again in the following weeks. Feel free to pick it up, though. |
There's another tricky case, all types that deref to slice also show the method |
Finally I found time to rebase this. I think it would be better to create an issue for the case @bluss pointed out, since I will not be able to tackle it anytime soon. @alexcrichton r+? |
that's fine, I'm happy with every improvement to rustdoc, so thanks! |
Also fixes dup #25673 |
⌛ Testing commit 8703883 with merge b7408c1... |
💔 Test failed - auto-linux-64-opt |
@bors: retry On Tue, May 26, 2015 at 6:58 AM, bors notifications@github.com wrote:
|
Fixes #24575
Fixes #25673
r? @alexcrichton