Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BTreeMap in build_sidebar_items #24494

Closed
wants to merge 1 commit into from
Closed

Use BTreeMap in build_sidebar_items #24494

wants to merge 1 commit into from

Conversation

mvdnes
Copy link
Contributor

@mvdnes mvdnes commented Apr 16, 2015

This ensures that later when generating HTML, the JSON will be sorted aswell.
We now have a more deterministic build of sidebar-items.js

Closes #24473

@mvdnes
Use BTreeMap in build_sidebar_items
61ad9fe 
This ensures that later when generating HTML, the JSON will be sorted aswell.
We now have a deterministic build of sidebar-items.js
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

Does this close #24473?

@mvdnes
Copy link
Contributor Author

mvdnes commented Apr 16, 2015

Ah yes! I did not find that issue earlier, but this should address exactly that.

@alexcrichton
Copy link
Member

@bors: r+ 61ad9fe

Thanks!

@alexcrichton
Copy link
Member

@bors: rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 16, 2015
@steveklabnik
Rollup merge of rust-lang#24494 - mvdnes:deterministic-sidebar, r=ale…
77adfb9 
…xcrichton

This ensures that later when generating HTML, the JSON will be sorted aswell.
We now have a more deterministic build of sidebar-items.js

Closes rust-lang#24473
@steveklabnik steveklabnik mentioned this pull request Apr 16, 2015
Merged
bors added a commit that referenced this pull request Apr 16, 2015
@bors
Auto merge of #24512 - steveklabnik:rollup, r=steveklabnik
fb4ab3b 
- Successful merges: #23782, #24455, #24490, #24493, #24494, #24496, #24498, #24499, #24501, #24502, #24506, #24507, #24508, #24509, #24510
- Failed merges: #24488
bors added a commit that referenced this pull request Apr 17, 2015
@bors
Auto merge of #24512 - steveklabnik:rollup, r=steveklabnik
88773f4 
- Successful merges: #23782, #24455, #24490, #24493, #24494, #24496, #24498, #24499, #24501, #24502, #24506, #24507, #24508, #24509, #24510
- Failed merges: #24488
bors added a commit that referenced this pull request Apr 17, 2015
@bors
Auto merge of #24512 - steveklabnik:rollup, r=steveklabnik
b7fb575 
- Successful merges: #23782, #24455, #24490, #24493, #24494, #24496, #24498, #24499, #24501, #24502, #24506, #24507, #24508, #24509, #24510
- Failed merges: #24488
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
@Manishearth
Rollup merge of rust-lang#24494 - mvdnes:deterministic-sidebar, r=ale…
e405b50 
…xcrichton

 This ensures that later when generating HTML, the JSON will be sorted aswell.
We now have a more deterministic build of sidebar-items.js

Closes rust-lang#24473
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
@Manishearth
Rollup merge of rust-lang#24494 - mvdnes:deterministic-sidebar, r=ale…
89bfacc 
…xcrichton

 This ensures that later when generating HTML, the JSON will be sorted aswell.
We now have a more deterministic build of sidebar-items.js

Closes rust-lang#24473
@steveklabnik
Copy link
Member

This was merged in #24512 , sorry, I rebased and forgot that'd screw it up :(

@mvdnes mvdnes deleted the deterministic-sidebar branch April 18, 2015 07:36
@mvdnes
Copy link
Contributor Author

mvdnes commented Apr 28, 2015

Is it possible to put this code in the beta as well? I don't think anyone would mind.
If it is too much of a hassle I understand, however the constant changes in sidebar-items.js do bug me still in beta.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rustdoc output slightly nondeterministic
5 participants
@mvdnes @rust-highfive @alexcrichton @steveklabnik @brson