Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destabilize format_args! internals #24312

Merged
merged 3 commits into from
Apr 14, 2015
Merged

Destabilize format_args! internals #24312

merged 3 commits into from
Apr 14, 2015

Commits on Apr 13, 2015

  1. Use the ecx.call_site() span for generating refs to format_args! inte… 

    …rnals

`format_args!` uses `#[allow_internal_unstable]` to access internal
functions and structs that are marked unstable. For this to work, the
spans on AST nodes referencing unstable internals must be equal (same
lo/hi values) to the `format_args!` call site, so that the stability
checker can recognize that the AST node was generated by the macro.
    @rprichard
    rprichard committed Apr 13, 2015
    Configuration menu
    Copy the full SHA
    bd26307 View commit details
    Browse the repository at this point in the history

  2. Destabilize format_args! internals. 

    Arguments, Formatters, and the various format traits remain stable. The
format_args! macro uses #[allow_internal_unstable] to allow it access to
the unstable things in core::fmt.

Destabilized things include a "v1" in their name:
 * core::fmt::rt
 * core::fmt::rt::v1 (the module and all contents)
 * core::fmt::ArgumentV1
 * core::fmt::ArgumentV1::new
 * core::fmt::ArgumentV1::from_usize
 * core::fmt::Arguments::new_v1
 * core::fmt::Arguments::new_v1_formatted

The unstable message was copied from that of std::io::_print.
    @rprichard
    rprichard committed Apr 13, 2015
    Configuration menu
    Copy the full SHA
    9cdc9e9 View commit details
    Browse the repository at this point in the history

  3. Remove pretty-expanded from tests that use format_args! 

    Now that the internals of `format_args!` are unstable, tests that use it
don't compile after pretty-printing (unless they also declare the necessary
feature).
    @rprichard
    rprichard committed Apr 13, 2015
    Configuration menu
    Copy the full SHA
    8615563 View commit details
    Browse the repository at this point in the history