Ensure that .join().unwrap() works #24254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Makes `Any + Send` implement `Debug`. Fixes rust-lang#21291
aturon
force-pushed
the
join-handle-debug
branch
from
d69ec5e
to
76d468a
Compare
|
Won't this mean |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 10, 2015
…chton Make `Box<Any + Send>` implement `Debug`. Fixes rust-lang#21291
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 10, 2015
…chton Make `Box<Any + Send>` implement `Debug`. Fixes rust-lang#21291
|
@reem the panic messages are still printed yeah, controlling that behavior would be nice though! |
bors
added a commit
that referenced
this pull request
Apr 11, 2015
Make `Box<Any + Send>` implement `Debug`. Fixes #21291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Box<Any + Send>implementDebug.Fixes #21291