Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hello-world.md #24148

Merged
merged 1 commit into from
Apr 7, 2015
Merged

Update hello-world.md #24148

merged 1 commit into from
Apr 7, 2015

Conversation

xfq
Copy link
Contributor

@xfq xfq commented Apr 7, 2015

People use programming language implementations like Ruby MRI, CPython, and SpiderMonkey for executing programs.

People use programming language *implementations* like Ruby MRI, CPython, and SpiderMonkey for executing programs.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@xfq
Copy link
Contributor Author

xfq commented Apr 7, 2015

r? @steveklabnik

@steveklabnik
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 7, 2015

📌 Commit 6eea426 has been approved by steveklabnik

@steveklabnik
Copy link
Member

@bors: rollup

@steveklabnik
Copy link
Member

Thank you! This is one of those things that's easy to get wrong in conversation :(

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2015
People use programming language *implementations* like Ruby MRI, CPython, and SpiderMonkey for executing programs.
bors added a commit that referenced this pull request Apr 7, 2015
@bors bors merged commit 6eea426 into rust-lang:master Apr 7, 2015
@xfq xfq deleted the patch-2 branch April 7, 2015 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants