Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Copy for Range and RangeFrom #23047

Closed
wants to merge 1 commit into from

Conversation

nwin
Copy link
Contributor

@nwin nwin commented Mar 4, 2015

That had been forgotten. See also #22511.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@aturon
Copy link
Member

aturon commented Mar 5, 2015

Thanks for the contribution!

Note that this is actually a dupe of #21431 and #21846, which has led to a recent RFC: rust-lang/rfcs#936

@nwin
Copy link
Contributor Author

nwin commented Mar 5, 2015

That slipped my attention. Seems to bitrot for a while.

It is pretty annoying not to being able to copy Range.

let foo = [0..0; 10]

Won’t work for example.

@aturon
Copy link
Member

aturon commented Mar 9, 2015

I'm going to close this PR for the time being; this is definitely a known issue, but we probably want to resolve it by introducing Pod (given the above cited issues).

Thanks again!

@aturon aturon closed this Mar 9, 2015
@nwin
Copy link
Contributor Author

nwin commented Jun 26, 2016

So, what is the status on this since the mentioned RFC has been closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants