std: Stabilize some ptr functions
#22729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
ptr-stabilization
branch
4 times, most recently
from
427e75c
to
ab45694
Compare
Specifically, the following actions were taken: * The `copy_memory` and `copy_nonoverlapping_memory` functions to drop the `_memory` suffix (as it's implied by the functionality). Both functions are now marked as `#[stable]`. * The `set_memory` function was renamed to `write_bytes` and is now stable. * The `zero_memory` function is now deprecated in favor of `write_bytes` directly. * The `Unique` pointer type is now behind its own feature gate called `unique` to facilitate future stabilization. * All type parameters now are `T: ?Sized` wherever possible and new clauses were added to the `offset` functions to require that the type is sized. [breaking-change]
| @@ -293,7 +293,7 @@ extern "rust-intrinsic" { | |||
| /// } | |||
| /// } | |||
| /// ``` | |||
| #[unstable(feature = "core")] | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
There was a problem hiding this comment.
Any reason not to rename these as well?
There was a problem hiding this comment.
I felt that intrinsics::copy_memory was more telling than intrinsics::copy, but laziness also kicked in as a desire to not deal with #[cfg(stage0)]
There was a problem hiding this comment.
Ah yes, the global namespace makes that clarification worthwhile. Carry on!
|
r=me (feel free to rename the intrinsics or not, doesn't matter) |
|
cc @gankro oh whoops forgot to cc you on opening, curious what you think about this as well |
|
On my phone, but what I see looks great! ❤️ |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 25, 2015
…turon Specifically, the following actions were takend: * The `copy_memory` and `copy_nonoverlapping_memory` functions to drop the `_memory` suffix (as it's implied by the functionality). Both functions are now marked as `#[stable]`. * The `set_memory` function was renamed to `write_bytes` and is now stable. * The `zero_memory` function is now deprecated in favor of `write_bytes` directly. * The `Unique` pointer type is now behind its own feature gate called `unique` to facilitate future stabilization. [breaking-change]
|
⌛ Testing commit ab45694 with merge 36e6aed... |
|
💔 Test failed - auto-mac-32-opt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, the following actions were takend:
copy_memoryandcopy_nonoverlapping_memoryfunctionsto drop the
_memorysuffix (as it's implied by the functionality). Bothfunctions are now marked as
#[stable].set_memoryfunction was renamed towrite_bytesand is now stable.zero_memoryfunction is now deprecated in favor ofwrite_bytesdirectly.
Uniquepointer type is now behind its own feature gate calleduniqueto facilitate future stabilization.
[breaking-change]