Require assoc types to outlive struct they are referenced from #22436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
issue-22246-bound-lifetimes-of-assoc-types
branch
from
c8406d6 to
4f461aa
Compare
|
@bors r=4f461aa |
|
🙀 You have the wrong number! Please try again with |
|
@bors r+ 4f461aa |
|
@bors: p=1 (this is blocking an important library stabilzation PR) |
|
⌛ Testing commit 4f461aa with merge a84505e... |
|
💔 Test failed - auto-mac-64-opt |
`no_late_bound_regions().unwrap()`, which allows us to write code that doesn't necessarily *fail* when there are higher-ranked trait bounds.
parameter environments so that it can be used elsewhere.
that it produces "outlives" relations for associated types. Add several tests relating to rust-lang#22246.
nikomatsakis
force-pushed
the
issue-22246-bound-lifetimes-of-assoc-types
branch
from
4f461aa to
9bb3b37
Compare
|
⌛ Testing commit 9bb3b37 with merge 4fe222e... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Feb 18, 2015
…soc-types, r=nikomatsakis Take 2. This PR includes a bunch of refactoring that was part of an experimental branch implementing [implied bounds]. That particular idea isn't ready to go yet, but the refactoring proved useful for fixing #22246. The implied bounds branch also exposed #22110 so a simple fix for that is included here. I still think some more refactoring would be a good idea here -- in particular I think most of the code in wf.rs is kind of duplicating the logic in implicator and should go, but I decided to post this PR and call it a day before diving into that. I'll write a bit more details about the solutions I adopted in the various bugs. I patched the two issues I was concerned about, which was the handling of supertraits and HRTB (the latter turned out to be fine, so I added a comment explaining why.) r? @pnkfelix (for now, anyway) cc @aturon [implied bounds]: http://smallcultfollowing.com/babysteps/blog/2014/07/06/implied-bounds/
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 19, 2015
…imes-of-assoc-types Take 2. This PR includes a bunch of refactoring that was part of an experimental branch implementing [implied bounds]. That particular idea isn't ready to go yet, but the refactoring proved useful for fixing rust-lang#22246. The implied bounds branch also exposed rust-lang#22110 so a simple fix for that is included here. I still think some more refactoring would be a good idea here -- in particular I think most of the code in wf.rs is kind of duplicating the logic in implicator and should go, but I decided to post this PR and call it a day before diving into that. I'll write a bit more details about the solutions I adopted in the various bugs. I patched the two issues I was concerned about, which was the handling of supertraits and HRTB (the latter turned out to be fine, so I added a comment explaining why.) r? @pnkfelix (for now, anyway) cc @aturon [implied bounds]: http://smallcultfollowing.com/babysteps/blog/2014/07/06/implied-bounds/
edwardw
added a commit
to edwardw/rust
that referenced
this pull request
Feb 21, 2015
PR rust-lang#22436 has fixed it. Closes rust-lang#22356
Merged
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 21, 2015
PR rust-lang#22436 has fixed it. Closes rust-lang#22356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2. This PR includes a bunch of refactoring that was part of an experimental branch implementing implied bounds. That particular idea isn't ready to go yet, but the refactoring proved useful for fixing #22246. The implied bounds branch also exposed #22110 so a simple fix for that is included here. I still think some more refactoring would be a good idea here -- in particular I think most of the code in wf.rs is kind of duplicating the logic in implicator and should go, but I decided to post this PR and call it a day before diving into that. I'll write a bit more details about the solutions I adopted in the various bugs. I patched the two issues I was concerned about, which was the handling of supertraits and HRTB (the latter turned out to be fine, so I added a comment explaining why.)
r? @pnkfelix (for now, anyway)
cc @aturon