Installer updates #22256
Merged
Installer updates #22256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quick start already links to the book. I think its not necessary to do in the build instructions.
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
This was referenced Feb 13, 2015
|
cc @steveklabnik This tweaks the very first section of the README and The Book's uninstall instructions. |
|
Oh, if not everything lands together in time for a nightly I expect it shouldn't result in major problems like last time. Now that the installers are versioned they should not clobber each other, but the combined build will probably fail. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 15, 2015
Highlights:
* Adds an 'uninstall.sh' script to `/usr/local/lib/rustlib/uninstall.sh`, the path to which is printed during installation.
* Components can be deselected during install, like `install.sh --without=rust-docs`.
* Components can be listed with `install.sh --list-components`.
* Vastly reduces spew during install (but supporting a `--verbose` option).
Typicall install run looks like:
```
brian@brianX1:~/dev/multirust⟫ sudo ./install.sh
[sudo] password for brian:
install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'cargo'
install: installing component 'rust-docs'
Rust is ready to roll.
```
Needs to be merged right before corresponding PRs to cargo and rust-packaging.
Fixes rust-lang#21117
Fixes rust-lang#20283
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Feb 16, 2015
Needs to land immediately after rust-lang/rust#22256.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
/usr/local/lib/rustlib/uninstall.sh, the path to which is printed during installation.install.sh --without=rust-docs.install.sh --list-components.--verboseoption).Typicall install run looks like:
Needs to be merged right before corresponding PRs to cargo and rust-packaging.
Fixes #21117
Fixes #20283