Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-gate #![no_std] and fix most syntax extensions #21988

Merged
merged 6 commits into from
Feb 8, 2015

Conversation

kmcallister
Copy link
Contributor

Fixes #21833.

[breaking-change]

r? @alexcrichton

The tests in #21912 will also need #[feature(no_std)]. If you're okay with both PRs, I can merge and test them.

@kmcallister
Copy link
Contributor Author

This causes problems in pretty printing, which I'm fixing.

@kmcallister
Copy link
Contributor Author

Still not quite right...

@kmcallister kmcallister changed the title Feature-gate #![no_std] Feature-gate #![no_std] and fix most syntax extensions Feb 6, 2015
@kmcallister
Copy link
Contributor Author

Okay, this includes #21912 and is passing local tests.

@alexcrichton
Copy link
Member

Nice! I think the entire fmt module can move to libcollections in fact, and other than that r=me

@kmcallister
Copy link
Contributor Author

@bors r=alexcrichton e7ed905

@bors
Copy link
Contributor

bors commented Feb 7, 2015

⌛ Testing commit e7ed905 with merge 466df21...

@bors
Copy link
Contributor

bors commented Feb 7, 2015

💔 Test failed - auto-mac-64-opt

@kmcallister
Copy link
Contributor Author

Rebased, and fixed that new test case.

@sfackler
Copy link
Member

sfackler commented Feb 7, 2015

@bors r+ 312f8bd

@bors
Copy link
Contributor

bors commented Feb 8, 2015

⌛ Testing commit 312f8bd with merge 74b8740...

bors added a commit that referenced this pull request Feb 8, 2015
Fixes #21833.

[breaking-change]

r? @alexcrichton 

The tests in #21912 will also need `#[feature(no_std)]`. If you're okay with both PRs, I can merge and test them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature-gate #[no_std]
4 participants