Enable test for android #21774

ejjeong · 2015-01-30T09:52:19Z

Now "make check-stage2-T-aarch64-linux-android-H-x86_64-unknown-linux-gnu" works ("make check" doesn't work correctly on aarch64-linux-android #21773)
Fix & enable debuginfo tests for android (Re-enable debuginfo tests on Android #10381)
Fix & enable more tests for android (both for arm/aarch64)
Enable many already-pass tests on android (both for arm/aarch64)

rust-highfive · 2015-01-30T09:52:35Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

alexcrichton · 2015-02-01T23:59:01Z

mk/install.mk

+$(foreach target,$(CFG_TARGET), \
+ $(if $(findstring $(CFG_ADB_DEVICE_STATUS),"true"), \
+  $(eval $(call INSTALL_RUNTIME_TARGET_N,$(taget),$(CFG_BUILD))) \
+  $(eval $(call INSTALL_RUNTIME_TARGET_CLEANUP_N,arm-linux-$(target))) \


Should this just be $(target) instead of arm-linux-$(target)? (to keep in line with the previous definition)

I've changed this. Thank you for finding this.

alexcrichton · 2015-02-03T16:58:55Z

Looks good to me! (needs a rebase though)

ejjeong · 2015-02-04T06:46:23Z

r? @alexcrichton

alexcrichton · 2015-02-04T07:22:59Z

@bors: r+ 49a520c

- Now "make check-stage2-T-aarch64-linux-android-H-x86_64-unknown-linux-gnu" works (#21773) - Fix & enable debuginfo tests for android (#10381) - Fix & enable more tests for android (both for arm/aarch64) - Enable many already-pass tests on android (both for arm/aarch64)

bors · 2015-02-04T18:26:06Z

⌛ Testing commit 49a520c with merge 9fd1a97...

bors · 2015-02-04T20:03:54Z

💔 Test failed - auto-linux-64-x-android-t

alexcrichton · 2015-02-06T04:38:25Z

mk/tests.mk

+   $(shell $(CFG_ADB) shell mkdir $(CFG_ADB_TEST_DIR)/$(target)) \
+   $(foreach crate,$(TARGET_CRATES), \
+    $(shell $(CFG_ADB) push $(TLIB2_T_$(target)_H_$(CFG_BUILD))/$(call CFG_LIB_GLOB_$(target),$(crate)) \
+                    $(CFG_ADB_TEST_DIR)/$(target))), \


It looks like the upload directory here changed from $(CFG_ADB_TEST_DIR) to ../$(target), maybe that caused a problem?

Oh but I see that LD_LIBRARY_PATH below changed. Perhaps somewhere else needs to be updated as well?

Yes, in fact I think I changed everywhere that uses $(CFG_ADB_TEST_DIR).
And I succeeded passing the whole testset on android, in my local environment.
(with platform-19 emulator and 64-bit ubuntu server, same as buildbot.)

ejjeong · 2015-02-10T12:59:21Z

I succeeded to reproduce the error by running tests separately, and removed the error.
r? @alexcrichton

alexcrichton · 2015-02-10T16:32:01Z

@bors: r+ 489f604

bors · 2015-02-10T17:56:50Z

⌛ Testing commit 489f604 with merge be28540...

bors · 2015-02-10T19:38:50Z

💔 Test failed - auto-linux-64-x-android-t

ejjeong · 2015-02-11T05:37:48Z

Added solib-search-path to help debugger find the correct library.
r? @alexcrichton

alexcrichton · 2015-02-11T17:38:22Z

@bors: r+ 4f14111

bors · 2015-02-11T20:45:19Z

⌛ Testing commit 4f14111 with merge bf43b03...

bors · 2015-02-11T22:31:30Z

💔 Test failed - auto-linux-64-x-android-t

ejjeong · 2015-02-12T12:05:18Z

It seems like it's the same issue as #11352.
@alexcrichton, could you check the version of gdb on buildbot? (gdb in android standalone toolchain)
if it's gdb 7.3, it cannot understand DWARF4 format.

Anyway, I think that the required NDK version for building android should be updated.
(and also for the buildbot, if it has the old gdb)
Before android ndk version r10, it only supports gdb-7.3,
and it doesn't understand DWARF4 format generated by LLVM by default.

(Alternative options)

Passing -C llvm-args="-dwarf-version=2" only when building debuginfo-test for old gdb
=> doesn't seem to work now. (I'm not sure this approach even makes sense.)
forcing DWARF2 for all android OS (like in Add appropriate LLVM module flags for debug info. #11864)
=> gdb in recent android ndk already supports DWARF4.

alexcrichton · 2015-02-16T04:18:19Z

Could the default dwarf version be lowered for android for now? We still do it for OSX and it's far easier than updating the bots.

ejjeong · 2015-02-16T09:10:44Z

@alexcrichton, I assumed that the gdb version of ndk on buildbot is 7.3,
and uploaded a patch that lowers the default dwarf version for android as you said.
And I created a new issue #22398 to remind this later.

alexcrichton · 2015-02-16T23:19:09Z

@bors: r+ 194d96e

bors · 2015-02-17T00:39:52Z

⌛ Testing commit 194d96e with merge bc74b37...

bors · 2015-02-17T02:07:23Z

💔 Test failed - auto-win-64-opt

Manishearth · 2015-02-17T02:20:47Z

/c/bot/slave/auto-win-64-opt/build/mk/tests.mk:379: recipe for target 'x86_64-pc-windows-gnu/stage2/test/stdtest-x86_64-pc-windows-gnu.exe' failed
error: linking with `gcc` failed: exit code: 1
note: "gcc" '"-Wl,--enable-long-section-names"' '"-fno-use-linker-plugin"' '"-Wl,--nxcompat"' '"-static-libgcc"' '"-m64"' '"-L"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib"' '"-o"' '"x86_64-pc-windows-gnu\\stage2\\test\\stdtest-x86_64-pc-windows-gnu.exe"' '"x86_64-pc-windows-gnu\\stage2\\test\\stdtest-x86_64-pc-windows-gnu.o"' '"-Wl,--gc-sections"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\libtest-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\libgetopts-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\libterm-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\libserialize-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\liblog-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\libstd-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\libcollections-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\librand-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\liballoc-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\liblibc-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\libunicode-4e7c5e5c.rlib"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib\\libcore-4e7c5e5c.rlib"' '"-L"' '"x86_64-pc-windows-gnu\\rt"' '"-L"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\llvm\\Release+Asserts\\lib"' '"-L"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\x86_64-pc-windows-gnu\\stage2\\bin\\rustlib\\x86_64-pc-windows-gnu\\lib"' '"-L"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\.rust\\bin\\x86_64-pc-windows-gnu"' '"-L"' '"C:\\bot\\slave\\auto-win-64-opt\\build\\obj\\bin\\x86_64-pc-windows-gnu"' '"-Wl,--whole-archive"' '"-Wl,-Bstatic"' '"-Wl,--no-whole-archive"' '"-Wl,-Bdynamic"' '"-lws2_32"' '"-luserenv"' '"-lkernel32"' '"-lws2_32"' '"-luserenv"' '"-lcompiler-rt"'
note: C:/program files/mingw-w64/x86_64-4.9.1-win32-seh-rt_v3-rev1/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/4.9.1/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot open output file x86_64-pc-windows-gnu\stage2\test\stdtest-x86_64-pc-windows-gnu.exe: Permission denied
collect2.exe: error: ld returned 1 exit status

error: aborting due to previous error
make: *** [x86_64-pc-windows-gnu/stage2/test/stdtest-x86_64-pc-windows-gnu.exe] Error 101

alexcrichton · 2015-02-17T04:14:58Z

@bors: retry

bors · 2015-02-17T08:25:02Z

⌛ Testing commit 194d96e with merge 72c0393...

bors · 2015-02-17T10:20:58Z

💔 Test failed - auto-win-32-nopt-t

alexcrichton · 2015-02-17T16:17:23Z

@bors: retry

bors · 2015-02-17T19:35:13Z

⌛ Testing commit 194d96e with merge 6c065fc...

- Now "make check-stage2-T-aarch64-linux-android-H-x86_64-unknown-linux-gnu" works (#21773) - Fix & enable debuginfo tests for android (#10381) - Fix & enable more tests for android (both for arm/aarch64) - Enable many already-pass tests on android (both for arm/aarch64)

bors · 2015-02-17T21:52:55Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@alexcrichton

…excrichton This commit has already been merged in rust-lang#21774, but i think it has been accidently overriden by rust-lang#22584 and rust-lang#22480. r? @alexcrichton

rust-highfive assigned alexcrichton Jan 30, 2015

ejjeong force-pushed the enable-test-for-android branch from 2d0cb73 to aae026d Compare January 30, 2015 18:16

alexcrichton reviewed Feb 1, 2015
View reviewed changes

ejjeong force-pushed the enable-test-for-android branch from 9e85fd5 to 49a520c Compare February 4, 2015 00:15

alexcrichton reviewed Feb 6, 2015
View reviewed changes

ejjeong and others added 5 commits February 10, 2015 15:48

Make aarch64-linux-android check with real target

5cbdf1d

Fix aarch64 test issues (same level to arm32)

d1e9a76

Support for test/debuginfo on android

6367afa

Enable test/debuginfo on android

b1af864

Enable some tests for android

fbe78e4

ejjeong force-pushed the enable-test-for-android branch from 49a520c to 328f32b Compare February 10, 2015 12:50

ejjeong added 2 commits February 10, 2015 21:53

Add one more depth on android test directory for multiple targets

abd7fd9

Remove duplicated configuration for android

489f604

ejjeong force-pushed the enable-test-for-android branch from 328f32b to 489f604 Compare February 10, 2015 12:54

Set solib-search-path to ensure android remote debugger works correctly.

4f14111

Lower the default dwarf version for android

194d96e

bors merged commit 194d96e into rust-lang:master Feb 17, 2015

ejjeong mentioned this pull request Feb 24, 2015

Replace deprecated getdtablesize() with sysconf(_SC_OPEN_MAX) for android aarch64 #22758

Merged

This was referenced Mar 16, 2015

"make check" doesn't work correctly on aarch64-linux-android #21773

Closed

Re-enable debuginfo tests on Android #10381

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable test for android #21774

Enable test for android #21774

ejjeong commented Jan 30, 2015

rust-highfive commented Jan 30, 2015

alexcrichton Feb 1, 2015

ejjeong Feb 2, 2015

alexcrichton commented Feb 3, 2015

ejjeong commented Feb 4, 2015

alexcrichton commented Feb 4, 2015

bors commented Feb 4, 2015

bors commented Feb 4, 2015

alexcrichton Feb 6, 2015

alexcrichton Feb 6, 2015

ejjeong Feb 6, 2015

ejjeong commented Feb 10, 2015

alexcrichton commented Feb 10, 2015

bors commented Feb 10, 2015

bors commented Feb 10, 2015

ejjeong commented Feb 11, 2015

alexcrichton commented Feb 11, 2015

bors commented Feb 11, 2015

bors commented Feb 11, 2015

ejjeong commented Feb 12, 2015

alexcrichton commented Feb 16, 2015

ejjeong commented Feb 16, 2015

alexcrichton commented Feb 16, 2015

bors commented Feb 17, 2015

bors commented Feb 17, 2015

Manishearth commented Feb 17, 2015

alexcrichton commented Feb 17, 2015

bors commented Feb 17, 2015

bors commented Feb 17, 2015

alexcrichton commented Feb 17, 2015

bors commented Feb 17, 2015

bors commented Feb 17, 2015

Enable test for android #21774

Enable test for android #21774

Conversation

ejjeong commented Jan 30, 2015

rust-highfive commented Jan 30, 2015

alexcrichton Feb 1, 2015

Choose a reason for hiding this comment

ejjeong Feb 2, 2015

Choose a reason for hiding this comment

alexcrichton commented Feb 3, 2015

ejjeong commented Feb 4, 2015

alexcrichton commented Feb 4, 2015

bors commented Feb 4, 2015

bors commented Feb 4, 2015

alexcrichton Feb 6, 2015

Choose a reason for hiding this comment

alexcrichton Feb 6, 2015

Choose a reason for hiding this comment

ejjeong Feb 6, 2015

Choose a reason for hiding this comment

ejjeong commented Feb 10, 2015

alexcrichton commented Feb 10, 2015

bors commented Feb 10, 2015

bors commented Feb 10, 2015

ejjeong commented Feb 11, 2015

alexcrichton commented Feb 11, 2015

bors commented Feb 11, 2015

bors commented Feb 11, 2015

ejjeong commented Feb 12, 2015

alexcrichton commented Feb 16, 2015

ejjeong commented Feb 16, 2015

alexcrichton commented Feb 16, 2015

bors commented Feb 17, 2015

bors commented Feb 17, 2015

Manishearth commented Feb 17, 2015

alexcrichton commented Feb 17, 2015

bors commented Feb 17, 2015

bors commented Feb 17, 2015

alexcrichton commented Feb 17, 2015

bors commented Feb 17, 2015

bors commented Feb 17, 2015