Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FullRange from the prelude and rename to RangeFull #21717

Merged
merged 4 commits into from
Jan 30, 2015
Merged

Remove FullRange from the prelude and rename to RangeFull #21717

merged 4 commits into from
Jan 30, 2015

Conversation

nrc
Copy link
Member

@nrc nrc commented Jan 28, 2015

alexcrichton
alexcrichton reviewed Jan 28, 2015
View reviewed changes
src/libcollections/str.rs
/// Any string that can be represented as a slice.
#[cfg(not(stage0))]
#[stable]
pub trait StrExt: Index<RangeFull, Output = str> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating, could this do something like:

#[cfg(stage0)]
use core::ops::FullRange as RangeFull;
#[cfg(not(stage0))]
use core::ops::RangeFull;

@alexcrichton
Copy link
Member

Looks great to me! I'd like to get @aturon's second opinion on the stability of RangeFull and explore some possibility of deduplication via renaming imports, but other than that r+

@nrc nrc force-pushed the prelude-fullrange branch from cdea9d9 to f7b0fca Compare January 28, 2015 23:05
@alexcrichton
Copy link
Member

@bors: r+ f7b0fca

@frewsxcv
Copy link
Member

Needs a rebase

@nrc nrc force-pushed the prelude-fullrange branch from f7b0fca to 023d49e Compare January 29, 2015 23:01
@nrc
Copy link
Member Author

nrc commented Jan 29, 2015

@bors r=acrichto f7b0fcaf2ca6a819b3c16c03935d9c9b5e4d8e82

@bors
Copy link
Contributor

bors commented Jan 29, 2015

🙀 You have the wrong number! Please try again with 023d49e.

@sinistersnare
Copy link
Contributor

Lol Bors.

@nrc
Copy link
Member Author

nrc commented Jan 30, 2015

@bors r=acrichto 023d49e

bors added a commit that referenced this pull request Jan 30, 2015
@bors
Auto merge of #21717 - nick29581:prelude-fullrange, r=acrichto
1a51eb9 
r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jan 30, 2015

⌛ Testing commit 023d49e with merge 1a51eb9...

@bors
Copy link
Contributor

bors commented Jan 30, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit 023d49e into rust-lang:master Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nrc @alexcrichton @frewsxcv @bors @sinistersnare @aturon