Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for default trait implementations #21689

Merged
merged 32 commits into from
Feb 24, 2015
Merged

Add support for default trait implementations #21689

merged 32 commits into from
Feb 24, 2015

Commits on Feb 22, 2015

  1. Add support for default trait impls in libsyntax

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    6a2f16e View commit details
    Browse the repository at this point in the history

  2. Fix fallout from libsyntax implementation

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    4148d53 View commit details
    Browse the repository at this point in the history

  3. look for default trait candidates

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    a962d47 View commit details
    Browse the repository at this point in the history

  4. Prefer other implementations over default ones

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    839a9de View commit details
    Browse the repository at this point in the history

  5. Don't allow default impls for traits outside their crate

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    ad3e748 View commit details
    Browse the repository at this point in the history

  6. Add negative impls for *const T and *mut T

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    bd511f7 View commit details
    Browse the repository at this point in the history

  7. Add negative impls for Sync

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    7ae8889 View commit details
    Browse the repository at this point in the history

  8. Fix rustdoc fallout

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    58a8103 View commit details
    Browse the repository at this point in the history

  9. Ensure default trait impls hold

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    4b09209 View commit details
    Browse the repository at this point in the history

  10. Use a Vec<N> instead of VecPerParamSpace<N>

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    d523acb View commit details
    Browse the repository at this point in the history

  11. Make default_trait_impls private and add accessor

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    7e38213 View commit details
    Browse the repository at this point in the history

  12. Rename DefTrait to DefaultImpl

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    d38aab3 View commit details
    Browse the repository at this point in the history

  13. address nits

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    f0e9bd9 View commit details
    Browse the repository at this point in the history

  14. Coherence for default trait implementations 

    - Don't allow multiple default trait implementations
- Allow positive trait implementations just for structs and enums when
  there's a default implementation for such trait.
    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    1e3ed61 View commit details
    Browse the repository at this point in the history

  15. Make Send/Sync go through the default implementation path

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    d215411 View commit details
    Browse the repository at this point in the history

  16. Some nits and cleanup

    @nikomatsakis @flaper87
    nikomatsakis authored and flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    40fffc9 View commit details
    Browse the repository at this point in the history

  17. Fix error codes

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    0be1e43 View commit details
    Browse the repository at this point in the history

  18. Test all the things

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    7213ef1 View commit details
    Browse the repository at this point in the history

  19. Add new test case showing that supertraits are not enough

    @nikomatsakis @flaper87
    nikomatsakis authored and flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    f7a75e0 View commit details
    Browse the repository at this point in the history

  20. check supertraits

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    64d33d8 View commit details
    Browse the repository at this point in the history

  21. some comments and nits

    @nikomatsakis @flaper87
    nikomatsakis authored and flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    24bdce4 View commit details
    Browse the repository at this point in the history

  22. mark candidate set ambig for defaulted traits where self-type is not … 

    …yet known
    @nikomatsakis @flaper87
    nikomatsakis authored and flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    e8df95d View commit details
    Browse the repository at this point in the history

  23. Check constituent types are known

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    38ef5ee View commit details
    Browse the repository at this point in the history

  24. Don't report bug for IntVar and FloatVar

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    1cc5a87 View commit details
    Browse the repository at this point in the history

  25. fix treatment of parameters and associated types

    @nikomatsakis @flaper87
    nikomatsakis authored and flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    640000a View commit details
    Browse the repository at this point in the history

  26. tweak exhaustive matching of ty_infer

    @nikomatsakis @flaper87
    nikomatsakis authored and flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    3ebc2ab View commit details
    Browse the repository at this point in the history

  27. Record default implementations in a separate step

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    6d1844c View commit details
    Browse the repository at this point in the history

  28. Add new test for impl precedence and remove unnecessary coherence rul… 

    …es that prevent the test from compiling.
    @nikomatsakis @flaper87
    nikomatsakis authored and flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    3343e9c View commit details
    Browse the repository at this point in the history

  29. Restore the coherence visitor and fix fallouts

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    d021c55 View commit details
    Browse the repository at this point in the history

  30. allow negative impls for traits that have a default impl

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    753db88 View commit details
    Browse the repository at this point in the history

  31. Fix test fallouts

    @flaper87
    flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    038d7e6 View commit details
    Browse the repository at this point in the history

  32. Add additional test case for superregion

    @nikomatsakis @flaper87
    nikomatsakis authored and flaper87 committed Feb 22, 2015
    Configuration menu
    Copy the full SHA
    3dcc631 View commit details
    Browse the repository at this point in the history