-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword &str coercion into viewing #18762
Conversation
Thanks for the PR! This looks like an improvement to me, but I want to give @steveklabnik a chance to weigh in. |
Specifically, with coerce as before, I interpreted it to mean that the underlying |
We haven't made a formal decision to use this 'view' terminology, but I do like it. I am neutral to mildly positive about this, so if @aturon likes it, r=me |
I don't get how r=me is supposed to work. I could just r=me at aturon or steveklabnik or alexcrichton and bors would automatically merge without their explicit approval (I know how it's supposed to be written but am not trying to write it properly here)? Isn't that just bypassing the review process? |
@Mdiner It's just an informal way of telling other reviewers that you're personally happy with the PR. Someone with reviewing rights still has to sign off. (bors will only pay attention to |
@steveklabnik Yeah, we should think more broadly about this terminology -- might be worth raising at the next weekly meeting. Want me to add to the agenda? In any case, I'm happy to land this for now. |
Okay. Thanks for clarification |
@aturon sounds great, yeah. I'll come prepared :) |
I had slight confusion when using this as a reference and was told it was imprecise. Most of the rewording was suggested by @huonw. cc @steveklabnik
…salsa-cancellation-error internal: wrap `salsa::Cycle`
I had slight confusion when using this as a reference and was told it was imprecise. Most of the rewording was suggested by @huonw.
cc @steveklabnik