rustc: Process #[cfg]/#[cfg_attr] on crates #18634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler |
| "a crate cannot expand to more than one item"); | ||
| let ast::Item { | ||
| attrs, span, node, ident: _, id: _, vis: _, | ||
| } = item.and_then(|x| x); |
There was a problem hiding this comment.
The item has type P<T> and currently P<T> doesn't support moving out, but the and_then closure consumes the pointer and gets the contents by value, so I figured I'd take it out via that.
I could also just add .move() :)
There was a problem hiding this comment.
Is there any reason to not just use clone?
There was a problem hiding this comment.
Ah this is trying to get the T out of the P<T>. This should ideally look like: let ast::Item { ... } = *item;
alexcrichton
force-pushed
the
cfg-attr-crate-level
branch
from
1142ec5 to
0131c48
Compare
| (match node { | ||
| ast::ItemMod(m) => m, | ||
| _ => panic!("fold converted a module to not a module"), | ||
| }, attrs, span) |
There was a problem hiding this comment.
The convention I tried to set for this (see fold.rs) is:
item.and_then(|ast::Item { attrs, span, node, .. }| match node {
ast::ItemMod(m) => (m, attrs, span),
_ => panic!("fold converted a module to not a module"),
})
alexcrichton
force-pushed
the
cfg-attr-crate-level
branch
2 times, most recently
from
269117b to
efa0bee
Compare
alexcrichton
force-pushed
the
cfg-attr-crate-level
branch
from
efa0bee to
dd9e355
Compare
bors
added a commit
that referenced
this pull request
Nov 7, 2014
…kler This commit implements processing these two attributes at the crate level as well as at the item level. When #[cfg] is applied at the crate level, then the entire crate will be omitted if the cfg doesn't match. The #[cfg_attr] attribute is processed as usual in that the attribute is included or not depending on whether the cfg matches. This was spurred on by motivations of #18585 where #[cfg_attr] annotations will be applied at the crate-level. cc #18585
This commit implements processing these two attributes at the crate level as well as at the item level. When #[cfg] is applied at the crate level, then the entire crate will be omitted if the cfg doesn't match. The #[cfg_attr] attribute is processed as usual in that the attribute is included or not depending on whether the cfg matches. This was spurred on by motivations of rust-lang#18585 where #[cfg_attr] annotations will be applied at the crate-level. cc rust-lang#18585
alexcrichton
force-pushed
the
cfg-attr-crate-level
branch
from
dd9e355 to
3dbd328
Compare
bors
added a commit
that referenced
this pull request
Nov 8, 2014
…kler This commit implements processing these two attributes at the crate level as well as at the item level. When #[cfg] is applied at the crate level, then the entire crate will be omitted if the cfg doesn't match. The #[cfg_attr] attribute is processed as usual in that the attribute is included or not depending on whether the cfg matches. This was spurred on by motivations of #18585 where #[cfg_attr] annotations will be applied at the crate-level. cc #18585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements processing these two attributes at the crate level as
well as at the item level. When #[cfg] is applied at the crate level, then the
entire crate will be omitted if the cfg doesn't match. The #[cfg_attr] attribute
is processed as usual in that the attribute is included or not depending on
whether the cfg matches.
This was spurred on by motivations of #18585 where #[cfg_attr] annotations will
be applied at the crate-level.
cc #18585