Remove the #[allow(non_uppercase_statics)] attribute from inside bitflags! #17781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,24 +22,25 @@ | |||
| /// # Example | |||
| /// | |||
| /// ```{.rust} | |||
| /// # #![allow(non_uppercase_statics)] | |||
There was a problem hiding this comment.
Is this still needed? It looks like some of the flags were also changed.
ftxqxd
force-pushed
the
bitflags-lints
branch
2 times, most recently
from
5fb1bf1 to
9663398
Compare
|
Comments addressed. |
|
|
||
| #[doc = "All possible permissions enabled."] | ||
| static AllPermissions = UserRWX.bits | GroupRWX.bits | OtherRWX.bits, | ||
| static ALL_PERMISSIONS = USER_RWX.bits | GROUP_RWX.bits | OTHER_RWX.bits, |
There was a problem hiding this comment.
To ease the migration path, could you keep the old statics, but mark them as #[deprecated]? Other than that this looks great to me!
For example, this renames `GroupRWX` to `GROUP_RWX`, and deprecates the old name. Code using these statics should be updated accordingly.
bors
added a commit
that referenced
this pull request
Oct 6, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 13, 2024
…r=Veykril feat: Implement diagnostic for `await` outside of `async` Closes rust-lang#17781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17773.