Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary allocation, update API name for starting the rustc dr... #17590

Merged
merged 1 commit into from
Oct 2, 2014
Merged

Remove unnecessary allocation, update API name for starting the rustc dr... #17590

merged 1 commit into from
Oct 2, 2014

Conversation

bjadamson
Copy link
Contributor

Removes an unnecessary allocation when passing the command line arguments to the librustc driver.

@alexcrichton
Copy link
Member

Oh dear, looks like this picked up some extra commits! @bjadamson, could you rebase those out of this PR?

@bjadamson
Copy link
Contributor Author

Hey Alex, sorry never done this before (I know how to rebase, but the guide I found for rebasing a pull request assumes I have push permissions: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request )

The commit looks correct on my end (in my fork)
https://github.com/bjadamson/rust/commit/d96faf7e7178f211148e2abcdb3282579817364e

I'm sure there's something obvious I'm missing (we don't get to use GitHub at work :( )

@alexcrichton
Copy link
Member

No problem! These commands should help out:

git checkout -b tmp 
git reset --hard fd6ec2d # your commit on this branch
git fetch origin # whatever the mozilla remote is called
git rebase origin/master # do the rebase
git push bjadamson tmp:rustc-improvements -f # force-push this branch

@bjadamson
Copy link
Contributor Author

Ok I think it's good! I think the key concept here was that I could automatically update this pull request just by pushing to my forked repo again. Thanks!

bors added a commit that referenced this pull request Oct 2, 2014
Removes an unnecessary allocation when passing the command line arguments to the librustc driver.
@bors bors closed this Oct 2, 2014
@bors bors merged commit d96faf7 into rust-lang:master Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants