Fix infinite recursion in type checker on recursive items #17264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
|
|
There was a problem hiding this comment.
Please add a comment here explaining briefly what this file does
|
LGTM, just a few nits to clear up. |
bkoropoff
force-pushed
the
issue-17252
branch
from
7d5475d
to
2d21489
Compare
|
Force pushed new version with fixes |
This new pass is run before type checking so that recursive items are detected beforehand. This prevents going into an infinite recursion during type checking when a recursive item is used in an array type. As a bonus, use `span_err` instead of `span_fatal` so multiple errors can be reported. Closes issue rust-lang#17252
bkoropoff
force-pushed
the
issue-17252
branch
from
2d21489
to
0818955
Compare
|
After some more discussion on IRC, I tweaked the pass to use |
bors
added a commit
that referenced
this pull request
Sep 17, 2014
Recursive items are currently detected in the `check_const` pass which runs after type checking. This means a recursive static item used as an array length will cause type checking to blow the stack. This PR separates the recursion check out into a separate pass which is run before type checking. Closes issue #17252 r? @nick29581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursive items are currently detected in the
check_constpass which runs after type checking. This means a recursive static item used as an array length will cause type checking to blow the stack. This PR separates the recursion check out into a separate pass which is run before type checking.Closes issue #17252
r? @nick29581