Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sized deallocation fixes #17012

Closed
wants to merge 5 commits into from
Closed

sized deallocation fixes #17012

wants to merge 5 commits into from

Conversation

thestinger
Copy link
Contributor

No description provided.

@huonw
Copy link
Member

huonw commented Sep 5, 2014

r? @nick29581

@bors bors closed this Sep 6, 2014
@thestinger thestinger deleted the sized branch September 10, 2014 06:55
bors added a commit that referenced this pull request Sep 10, 2014
Previously, some parts of this optimization were impossible because the
alignment passed to the free function was not correct. That was fully
fixed by #17012.

Closes #17092
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 24, 2023
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 25, 2023
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2023
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 27, 2023
lnicola pushed a commit to lnicola/rust that referenced this pull request May 26, 2024
Fix inconsistent cwd of `run` and `debug` command in client

Fix rust-lang#17012. Also related to rust-lang#13022 and rust-lang#15993.

When the `kind` of runnable is `bin`, Cargo would use the workspace root as the cwd for the `run` command; otherwise, Cargo defaults to the package root as the cwd for `run`.

Initially, r-a assumed the workspace root as the cwd for all runnables in `debug` command, which led to issue rust-lang#13022. In this case, during unit testing, the `run` command would use the package root while `debug` would use the workspace root, causing inconsistency.

PR rust-lang#15993 addressed this problem by using the package root as the cwd for `debug` command. However, it also resulted in an inconsistency: when executing the `run` command within the main fn of a package (whose target is `bin`), Cargo would use the workspace root, whereas `debug` would use the package root, leading to issue rust-lang#17012.

The preferable approach is to determine the cwd based on the runnable's type. To resolve this, this PR introduces a new `cwd` field within `CargoRunnable`, allowing r-a to decide the appropriate cwd depending on the specific kind of the runnable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants