green/native: Be more resilient to spawn failures #15944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| use mutex::{StaticNativeMutex, NATIVE_MUTEX_INIT}; | ||
|
|
||
| static mut TASK_COUNT: atomics::AtomicUint = atomics::INIT_ATOMIC_UINT; | ||
| static mut TASK_LOCK: StaticNativeMutex = NATIVE_MUTEX_INIT; | ||
|
|
||
| pub fn increment() { | ||
| pub struct Token(()); |
There was a problem hiding this comment.
This () is to ensure it can't be constructed outside this module? (Would Token { _force_private: () } be more descriptive?)
There was a problem hiding this comment.
That is indeed correct! Pushed with an explicit field now.
|
(Needs a rebase.) |
When a new task fails to spawn, it triggers a task failure of the spawning task. This ends up causing runtime aborts today because of the destructor bomb in the Task structure. The bomb doesn't actually need to go off until *after* the task has run at least once. This now prevents a runtime abort when a native thread fails to spawn.
Previously, the call to bookkeeping::increment() was never paired with a decrement when the spawn failed (due to unwinding). This fixes the problem by returning a "bomb" from increment() which will decrement on drop, and then moving the bomb into the child task's procedure which will be dropped naturally.
Like with libnative, when a green task failed to spawn it would leave the world in a corrupt state where the local scheduler had been dropped as well as the local task. Also like libnative, this patch sets up a "bomb" which when it goes off will restore the state of the world.
bors
added a commit
that referenced
this pull request
Jul 30, 2014
Previously both spawning mechanisms were not resilient to task failures which were initiated from the task spawning infrastructure. Closes #15895
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2023
Update Arch Linux package URL in manual.adoc The old URL returns 404 now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously both spawning mechanisms were not resilient to task failures which were initiated from the task spawning infrastructure.
Closes #15895