Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15129 #15130

Closed
wants to merge 1 commit into from
Closed

Fix #15129 #15130

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 23, 2014

Add support for unit literals to const_eval.

@ghost
Copy link
Author

ghost commented Jun 23, 2014

It's unfortunate this pattern matching refactor had led to so many regressions but at least we're building up test coverage the hard way. Hopefully after all the changes I'd like to make, the whole thing will be in a much better shape!

@ghost
Copy link
Author

ghost commented Jun 24, 2014

I've now added a test for this as well:

static x: [uint, ..()] = [];
fn main() {
}

which happily compiled in master.

@alexcrichton
Copy link
Member

Looks like this needs a rebase

Add support for unit literals to const_eval.
@ghost
Copy link
Author

ghost commented Jun 24, 2014

@alexcrichton Done.

@ghost ghost deleted the issue-15129 branch July 2, 2014 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant