cg_llvm: Replace enum MetadataType with a list of MetadataKindId constants
#147181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
|
rustbot has assigned @petrochenkov. Use |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 30, 2025
Rollup of 6 pull requests Successful merges: - #142506 (Add `Path::has_trailing_sep` and related methods) - #146886 (Add repr(align(2)) to RcInner and ArcInner) - #147166 (several small `proc_macro` cleanups) - #147172 (bootstrap: build bootstrap docs with in-tree rustdoc) - #147181 (cg_llvm: Replace enum `MetadataType` with a list of `MetadataKindId` constants) - #147187 (remove unnecessary test directives) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 30, 2025
Rollup merge of #147181 - Zalathar:fixed-metadata, r=petrochenkov cg_llvm: Replace enum `MetadataType` with a list of `MetadataKindId` constants The metadata kind ID values declared in `MetadataType` are not part of the LLVM-C API, and are not machine-checked. If a value that we use ever goes out of sync with LLVM, the resulting bugs could be difficult to track down. And the existing values lack any clear indication of what LLVM declarations they correspond to. On top of that, we currently have another way of expressing metadata kind IDs in the form of `MetadataKindId`, which creates confusing inconsistency in LLVM bindings. This PR therefore consolidates all usage of “fixed” metadata kind IDs into one list of `MetadataKindId` constants, which is backed by static assertions in our C++ code that match them up with named anonymous-enum variants in `llvm::LLVMContext`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata kind ID values declared in
MetadataTypeare not part of the LLVM-C API, and are not machine-checked. If a value that we use ever goes out of sync with LLVM, the resulting bugs could be difficult to track down. And the existing values lack any clear indication of what LLVM declarations they correspond to.On top of that, we currently have another way of expressing metadata kind IDs in the form of
MetadataKindId, which creates confusing inconsistency in LLVM bindings.This PR therefore consolidates all usage of “fixed” metadata kind IDs into one list of
MetadataKindIdconstants, which is backed by static assertions in our C++ code that match them up with named anonymous-enum variants inllvm::LLVMContext.