rustdoc js: Even more typechecking improvments #145742
Conversation
rustbot
added
A-rustdoc-search
|
Some changes occurred in HTML/CSS/JS. |
| clearTooltipHoverTimeout(window.CURRENT_TOOLTIP_ELEMENT); | ||
| return; | ||
| } | ||
| window.hideAllModals(false); | ||
| const wrapper = document.createElement("div"); | ||
| const wrapper = Object.assign(document.createElement("div"), {TOOLTIP_BASE: e}); |
There was a problem hiding this comment.
Is there an advantage assigning a field this way? It's less readable that writing wrapper.TOOLTIP_BASE = e; (which should have been how we should have written it in the first place).
There was a problem hiding this comment.
the way i'm writing it results in a variable of type HTMLDivElement & { TOOLTIP_BASE: HTMLElement }, while what you're reccomendeding would result in a variable of type HTMLDivElement, and then you would try assigning to a field that does not exist on that type, which results in a type error.
unfortunately there's no way to have an expression that changes the type of a variable that already exists, as handy as that would be (it would be especially helpful for functions that finish initializing partially initialized objects).
I don't know of any other way to avoid a type error besides a cast, which I would quite like to avoid.
There was a problem hiding this comment.
When a tool forces to write less good code, it's generally not a great sign... Please add a comment on why it's done this way then. I'll review one last time once done and then merge.
There was a problem hiding this comment.
Added a comment.
lolbinarycat
force-pushed
the
rustdoc-search-type-cleanup-continued
branch
from
c3ade75 to
d006653
Compare
|
Thanks! r=me once CI pass |
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-search-type-cleanup-continued
branch
from
d006653 to
771c641
Compare
|
@bors r=GuillaumeGomez |
bors
added
S-waiting-on-bors
Rollup of 28 pull requests Successful merges: - #132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type) - #137396 (Recover `param: Ty = EXPR`) - #137457 (Fix host code appearing in Wasm binaries) - #142185 (Convert moves of references to copies in ReferencePropagation) - #144648 (Implementation: `#[feature(nonpoison_rwlock)]`) - #144897 (print raw lifetime idents with r#) - #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability) - #145380 (Add codegen-llvm regression tests) - #145573 (Add an experimental unsafe(force_target_feature) attribute.) - #145597 (resolve: Remove `ScopeSet::Late`) - #145633 (Fix some typos in LocalKey documentation) - #145641 (On E0277, point at type that doesn't implement bound) - #145669 (rustdoc-search: GUI tests check for `//` in URL) - #145695 (Introduce ProjectionElem::try_map.) - #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64) - #145726 (Experiment: Reborrow trait) - #145731 (Make raw pointers work in type-based search) - #145736 (triagebot: Update style team reviewers) - #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.) - #145742 (rustdoc js: Even more typechecking improvments ) - #145743 (doc: fix some typos in comment) - #145745 (tests: Ignore basic-stepping.rs on LoongArch) - #145747 (Refactor lint buffering to avoid requiring a giant enum) - #145751 (fix(lexer): Allow '-' in the frontmatter infostring continue set) - #145761 (Add aarch64_be-unknown-hermit target) - #145762 (convert strings to symbols in attr diagnostics) - #145763 (Ship LLVM tools for the correct target when cross-compiling) - #145765 (Revert suggestions for missing methods in tuples) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #145742 - lolbinarycat:rustdoc-search-type-cleanup-continued, r=GuillaumeGomez rustdoc js: Even more typechecking improvments made another pass at eliminating typescript errors, this time mainly focused on adding fields to `window` that weren't declared before. r? `@notriddle`
made another pass at eliminating typescript errors, this time mainly focused on adding fields to
windowthat weren't declared before.r? @notriddle