Remove the omit_gdb_pretty_printer_section attribute #144738
Open
+209
−387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in src/tools/compiletest cc @jieyouxu Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
bjorn3
force-pushed
the
remove_omit_gdb_pretty_printer_section
branch
from
c76e848 to
6ecc1c3
Compare
|
Almost all tests pass without |
|
r? jieyouxu |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Thanks, you can r=me after PR CI is green. |
Closed
|
@bors r=jieyouxu |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 1, 2025
…ter_section, r=jieyouxu Remove the omit_gdb_pretty_printer_section attribute Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.
bors
added a commit
that referenced
this pull request
Aug 1, 2025
Rollup of 10 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #135771 ([rustdoc] Add support for associated items in "jump to def" feature) - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #144614 (Fortify RemoveUnneededDrops test.) - #144703 ([test][AIX] ignore extern_weak linkage test) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144756 (detect infinite recursion with tail calls in ctfe) - #144766 (Add human readable name "Cygwin") r? `@ghost` `@rustbot` modify labels: rollup
bors
added
S-waiting-on-author
|
@bors2 try jobs=aarch64-apple |
rust-bors bot
added a commit
that referenced
this pull request
Aug 1, 2025
…, r=<try> Remove the omit_gdb_pretty_printer_section attribute try-job: aarch64-apple
bjorn3
force-pushed
the
remove_omit_gdb_pretty_printer_section
branch
from
cd8ad69 to
3d234c7
Compare
|
Unknown labels: T-bootstrap, A-LLVM, A-attributes, A-testsuite, A-rustc-dev-guide, A-compiletest |
Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.
bjorn3
force-pushed
the
remove_omit_gdb_pretty_printer_section
branch
from
3d234c7 to
ae2f8d9
Compare
|
Unknown labels: A-attributes, A-testsuite, A-compiletest, T-bootstrap, A-rustc-dev-guide, A-LLVM |
|
Turns out the tests were expecting pretty printers to always be on for LLDB. I've made the test directive only apply to GDB and renamed it accordingly. |
|
@rustbot ready |
jieyouxu
added
S-waiting-on-review
|
Normally I would bump the p on this PR because it has a lot of test changes and so is conflict-prone, but there's quite a few backports / release process PRs in queue so I didn't want to do that. @bors r+ |
bors
added
S-waiting-on-bors
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Aug 3, 2025
…ter_section, r=jieyouxu Remove the omit_gdb_pretty_printer_section attribute Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Aug 3, 2025
…ter_section, r=jieyouxu Remove the omit_gdb_pretty_printer_section attribute Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.
bors
added a commit
that referenced
this pull request
Aug 3, 2025
Rollup of 11 pull requests Successful merges: - #142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - #144650 (Additional tce tests) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144790 (Multiple bounds checking elision failures) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) - #144843 (Weekly `cargo update`) Failed merges: - #144794 (Port `#[coroutine]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling loading of pretty printers in the debugger itself is more reliable. Before this commit the .gdb_debug_scripts section couldn't be included in dylibs or rlibs as otherwise there is no way to disable the section anymore without recompiling the entire standard library.