Implementation: #[feature(nonpoison_condvar)]
#144651
Open
+766
−269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the equivalent `nonpoison` types to the `poison::condvar` module. These types and implementations are gated under the `nonpoison_condvar` feature gate.
Adds tests for the `nonpoison::Mutex` variant by using a macro to duplicate the existing `poison` tests. Note that all of the tests here are adapted from the existing `poison` tests. Also steals the `test_mutex_arc_condvar` test from `mutex.rs`.
Since `WaitTimeoutResult` is poison-agnostic, we want to use the same type for both variants of `Condvar`.
rustbot
added
S-waiting-on-review
connortsui20
changed the title
connortsui20
changed the title
#[feature(nonpoison_condvar)]
This was referenced Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #134645
This PR continues the effort made in #144022 by adding the implementation of
nonpoison::condvar.Many of the changes here are similar to the changes made to implement
nonpoison::mutex.There are two other changes here. The first is that the
Barrierimplementation is migrated to use thenonpoison::Condvarinstead of thepoisonvariant. The second (which might be subject to some discussion) is thatWaitTimeoutResultis moved up tomod.rs, as bothcondvarvariants need that type (and I do not know if there is a better place to put it now).Related PRs
nonpoison_rwlockimplementation: Implementation:#[feature(nonpoison_rwlock)]#144648nonpoison_onceimplementation: Implementation:#[feature(nonpoison_once)]#144653