Complete span AST lowering.

[cjgillot]

r? @ghost

[cjgillot]

@bors try @rust-timer queue

[rust-bors]

⌛ Trying commit 7db72f8 with merge 0ff4763…

To cancel the try build, run the command @bors try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 0ff4763 (0ff4763f958fb6b4e8b2e87fe41a5433fccb0401, parent: f8e355c230c6eb7b78ffce6a92fd81f78c890524)

[rust-timer]

Finished benchmarking commit (0ff4763): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.9%, -0.3%]	8
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-1.9%, -0.3%]	8

Max RSS (memory usage)

Results (secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.1%, 2.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-3.4%, -2.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-3.4%, -2.2%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.942s -> 465.314s (-0.13%)
Artifact size: 376.74 MiB -> 376.79 MiB (0.01%)

[rustbot]

Some changes occurred in compiler/rustc_ast_lowering/src/format.rs

cc @m-ou-se

[compiler-errors]

r? compiler-errors @bors r+

[bors]

📌 Commit 7db72f8 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7db72f8 with merge e2401a2...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v4' (SHA:11bd71901bbe5b1630ceea73d27597364c9af683)
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/11bd71901bbe5b1630ceea73d27597364c9af683'. Error: Response status code does not indicate success: 429 (Too Many Requests). C5F6:13EF5:2E0A5:41FC0:68882B4E
##[warning]Back off 12.931 seconds before retry.
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/11bd71901bbe5b1630ceea73d27597364c9af683'. Error: Response status code does not indicate success: 429 (Too Many Requests). 4B83:337065:71001:AD2EB:68882B5B
##[warning]Back off 14.976 seconds before retry.
##[error]Response status code does not indicate success: 429 (Too Many Requests).

[cjgillot]

I can't find the error.
@bors retry

[bors]

⌛ Testing commit 7db72f8 with merge 686bc1c...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 686bc1c to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ac0cb05 (parent) -> 686bc1c (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 686bc1c5f9c06762b18082434c04d514acf6707e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-aarch64-apple: 5110.0s -> 7478.4s (46.3%)
2. dist-x86_64-apple: 12529.8s -> 7315.4s (-41.6%)
3. x86_64-apple-2: 5120.1s -> 3684.0s (-28.0%)
4. aarch64-apple: 6328.2s -> 4886.7s (-22.8%)
5. dist-apple-various: 4010.4s -> 4880.1s (21.7%)
6. pr-check-2: 2650.0s -> 2151.0s (-18.8%)
7. i686-gnu-nopt-1: 8426.4s -> 7264.9s (-13.8%)
8. x86_64-gnu-llvm-19: 2892.8s -> 2496.5s (-13.7%)
9. x86_64-apple-1: 6199.0s -> 6947.6s (12.1%)
10. x86_64-rust-for-linux: 2907.6s -> 2563.2s (-11.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (686bc1c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.8%, -0.2%]	9
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-1.8%, -0.2%]	9

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.868s -> 469.682s (0.17%)
Artifact size: 376.82 MiB -> 376.80 MiB (-0.01%)